IGNITE-27759 Remove redundant serialization of SnapshotHandlerResult#node #12702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vladsz83
reviewed
Feb 10, 2026
|
|
||
| if (res.error() != null) { | ||
| bldr.addException(res.node(), res.error()); | ||
| bldr.addException(cctx.discovery().node(nodeId), res.error()); |
Contributor
There was a problem hiding this comment.
What if node is already gone?
Contributor
Author
There was a problem hiding this comment.
This case is nearly impossible (the distributed process should cover it). But even if a node goes down after receiving the results, I now use historicalNode. Thanks!
| private IgniteInternalFuture<Void> completeHandlersAsyncIfNeeded( | ||
| SnapshotOperation snpOp, | ||
| Collection<SnapshotOperationResponse> res | ||
| Map<UUID, SnapshotOperationResponse> res |
| for (SnapshotOperationResponse snpRes : res) { | ||
| if (snpRes == null || snpRes.handlerResults() == null) | ||
| continue; | ||
| res.forEach((nodeId, r) -> { |
Contributor
There was a problem hiding this comment.
Suggestion: (nodeId, r) -> (nodeId, snpRes)
| continue; | ||
| res.forEach((nodeId, r) -> { | ||
| if (r == null || r.handlerResults() == null) | ||
| return; |
Contributor
Author
There was a problem hiding this comment.
Previously, iteration was performed via a loop; now it is done using a lambda
NSAmelchev
commented
Feb 10, 2026
| private IgniteInternalFuture<Void> completeHandlersAsyncIfNeeded( | ||
| SnapshotOperation snpOp, | ||
| Collection<SnapshotOperationResponse> res | ||
| Map<UUID, SnapshotOperationResponse> res |
NSAmelchev
commented
Feb 10, 2026
| continue; | ||
| res.forEach((nodeId, r) -> { | ||
| if (r == null || r.handlerResults() == null) | ||
| return; |
Contributor
Author
There was a problem hiding this comment.
Previously, iteration was performed via a loop; now it is done using a lambda
Vladsz83
approved these changes
Feb 11, 2026
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.