Skip to content

FINERACT-2421: Loan repayment transaction template with overpaid loan #5462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
alberto-art3ch wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

FINERACT-2421: Loan repayment transaction template with overpaid loan #5462

alberto-art3ch wants to merge 1 commit into from
+48 −39

Conversation

@alberto-art3ch
Copy link
Contributor

@alberto-art3ch alberto-art3ch commented Feb 7, 2026

Description

There was an exception in the Loan repayment transaction template with overpaid loan due the SQL sentence was not consider the overpaid loan case

FINERACT-2421

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@adamsaghy
Copy link
Contributor

adamsaghy commented Feb 11, 2026 

    Test uc2() FAILED
  
    org.apache.fineract.client.util.CallFailedRuntimeException: HTTP failed: Request{method=GET, url=https://localhost:8443/fineract-provider/api/v1/loans/12/transactions/template?command=repayment&dateFormat=dd%20MMMM%20yyyy&transactionDate=15%20February%202023&locale=en, tags={class retrofit2.Invocation=org.apache.fineract.client.services.LoanTransactionsApi.retrieveTransactionTemplate() [12, repayment, dd MMMM yyyy, 15 February 2023, en, null]}}; Response{protocol=http/1.1, code=500, message=, url=https://localhost:8443/fineract-provider/api/v1/loans/12/transactions/template?command=repayment&dateFormat=dd%20MMMM%20yyyy&transactionDate=15%20February%202023&locale=en}; errorBody: <!doctype html><html lang="en"><head><title>HTTP Status 500 – Internal Server Error</title><style type="text/css">body {font-family:Tahoma,
        at app//org.apache.fineract.integrationtests.AdvancedPaymentAllocationLoanRepaymentScheduleTest.lambda$uc2$1(AdvancedPaymentAllocationLoanRepaymentScheduleTest.java:284)
  
    Test uc3() FAILED (1s)
  
    org.apache.fineract.client.util.CallFailedRuntimeException: HTTP failed: Request{method=GET, url=https://localhost:8443/fineract-provider/api/v1/loans/13/transactions/template?command=repayment&dateFormat=dd%20MMMM%20yyyy&transactionDate=15%20February%202023&locale=en, tags={class retrofit2.Invocation=org.apache.fineract.client.services.LoanTransactionsApi.retrieveTransactionTemplate() [13, repayment, dd MMMM yyyy, 15 February 2023, en, null]}}; Response{protocol=http/1.1, code=500, message=, url=https://localhost:8443/fineract-provider/api/v1/loans/13/transactions/template?command=repayment&dateFormat=dd%20MMMM%20yyyy&transactionDate=15%20February%202023&locale=en}; errorBody: <!doctype html><html lang="en"><head><title>HTTP Status 500 – Internal Server Error</title><style type="text/css">body {font-family:Tahoma,
        at app//org.apache.fineract.integrationtests.AdvancedPaymentAllocationLoanRepaymentScheduleTest.lambda$uc3$2(AdvancedPaymentAllocationLoanRepaymentScheduleTest.java:356)

  org.apache.fineract.integrationtests.savings.SavingsInterestPostingTest
  
    Test testSavingsInterestPosting_Works_ForMultipleAccounts() FAILED (7.7s)
  
    org.apache.fineract.client.util.CallFailedRuntimeException: HTTP failed: Request{method=POST, url=https://localhost:8443/fineract-provider/api/v1/savingsaccounts/80?command=activate, tags={class retrofit2.Invocation=org.apache.fineract.client.services.SavingsAccountApi.handleCommands6() [80, class PostSavingsAccountsAccountIdRequest {
        activatedOnDate: 01 January 2023
        approvedOnDate: null
        closedOnDate: null
        dateFormat: dd MMMM yyyy
        locale: en
        withdrawBalance: null
    }, activate]}}; Response{protocol=http/1.1, code=401, message=, url=https://localhost:8443/fineract-provider/api/v1/savingsaccounts/80?command=activate}; errorBody: {"timestamp":"2026-02-07T08:16:13.762Z","status":401,"error":"Unauthorized","path":"/fineract-provider/api/v1/savingsaccounts/80"}
        at app//org.apache.fineract.integrationtests.savings.SavingsInterestPostingTest.lambda$testSavingsInterestPosting_Works_ForMultipleAccounts$2(SavingsInterestPostingTest.java:62)
  
   org.apache.fineract.integrationtests.ExternalIdSupportIntegrationTest
  
    Test loan() PASSED (5s)
    Test test() FAILED (1.2s)
  
    org.apache.fineract.client.util.CallFailedRuntimeException: HTTP failed: Request{method=GET, url=https://localhost:8443/fineract-provider/api/v1/loans/external-id/9526bbc1-4abf-435f-84a8-1bf151b1009a/transactions/template?command=repayment, tags={class retrofit2.Invocation=org.apache.fineract.client.services.LoanTransactionsApi.retrieveTransactionTemplate1() [9526bbc1-4abf-435f-84a8-1bf151b1009a, repayment, null, null, null, null]}}; Response{protocol=http/1.1, code=500, message=, url=https://localhost:8443/fineract-provider/api/v1/loans/external-id/9526bbc1-4abf-435f-84a8-1bf151b1009a/transactions/template?command=repayment}; errorBody: <!doctype html><html lang="en"><head><title>HTTP Status 500 – Internal Server Error</title><style type="text/css">body {font-family:Tahoma,
        at app//org.apache.fineract.integrationtests.ExternalIdSupportIntegrationTest.test(ExternalIdSupportIntegrationTest.java:158)

@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2421/loan-repayment-template-with-loan-overpaid branch from 3633136 to 073d50f Compare February 11, 2026 16:10
@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2421/loan-repayment-template-with-loan-overpaid branch from 073d50f to e10103a Compare February 11, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alberto-art3ch @adamsaghy