Skip to content

Conversation

@jvrubel
Copy link
Contributor

@jvrubel jvrubel commented Feb 9, 2026

These changes allow customization of the camel command in order to support camel-launcher.

There are also differences from the closed PR with the same title. This one only contains the rework itself alongside some minor fixes. I also greatly simplified it by removing the property out of the container service and keeping it as a simple system property as @mcarlett suggested.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@jvrubel jvrubel force-pushed the implement-camel-launcher branch from ad00ff2 to d476966 Compare February 9, 2026 13:41

protected String executeBackground(final String command) {
return containerService.executeBackground(command);
return containerService.executeGenericCommand(MAIN_COMMAND + " " + command + " --background");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why you are implementing again what we already have in containerService.executeBackground() ? is this a different behaviour?


private static final String DATA_FOLDER = System.getProperty(CliProperties.DATA_FOLDER);

private static final String MAIN_COMMAND = System.getProperty("cli.service.command");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think to implement a getMainCommand() method in the CliService class so that we have just one place to retrieve the property? you can use so containerService.getMainCommand() instead of MAIN_COMMAND in all the places

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants