ARTEMIS-5895 OpenWire TX Commit shouldn't send Success when in doubt#6247
Merged
clebertsuconic merged 1 commit intoapache:mainfrom Feb 24, 2026
Merged
ARTEMIS-5895 OpenWire TX Commit shouldn't send Success when in doubt#6247clebertsuconic merged 1 commit intoapache:mainfrom
clebertsuconic merged 1 commit intoapache:mainfrom
Conversation
clebertsuconic
force-pushed
the
failover
branch
5 times, most recently
from
8d22289 to
525f801
Compare
Contributor
|
Running in CI the OpenWireSharedStoreFailoverSmokeTest seems to fail sporadically and the test org.apache.activemq.artemis.tests.integration.openwire.amq.ValidateAddressSizeTest#testValidateSizeChangeMessageEstimate is failing on each run. |
clebertsuconic
force-pushed
the
failover
branch
from
525f801 to
30ba3ac
Compare
clebertsuconic
force-pushed
the
failover
branch
from
30ba3ac to
9127044
Compare
Contributor
Author
|
I'm moving to sharedStorage to a different place now. and I think the storage in our CI might be using seomthing that doesn't actually support libaio, so I changed it to NIO to make sure the sync is respected on the test. I ran the test for about 300 times on my machine and it doesn't fail.. but I will add a couople more runs to make sure. |
Contributor
Author
|
I will merge this PR, since it's simple enough. if anything is still needed I will come back to it as soon as someone ping me. |
clebertsuconic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.