You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if ARROW_TEST=ON the arrow_c_data_integration library is not built. This has been seen on Release verification for 23.0.0 and 23.0.1.
What changes are included in this PR?
Build arrow_c_data_integration library if ARROW_BUILD_INTEGRATION=ON regardless of ARROW_TEST value.
Are these changes tested?
Yes, I've temporarily modified the crossbow job to run both tests and integration and validated the commit fixes the problem and it failed without the fix.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
Component: C++
awaiting committer review
Rationale for this change
Currently if
ARROW_TEST=ONthe arrow_c_data_integration library is not built. This has been seen on Release verification for 23.0.0 and 23.0.1.What changes are included in this PR?
Build
arrow_c_data_integrationlibrary ifARROW_BUILD_INTEGRATION=ONregardless ofARROW_TESTvalue.Are these changes tested?
Yes, I've temporarily modified the crossbow job to run both tests and integration and validated the commit fixes the problem and it failed without the fix.
Are there any user-facing changes?
No
libarrow_c_data_integration.soisn't built withARROW_BUILD_TESTS=ONandARROW_BUILD_INTEGRATION=ON#48862