Fix workflow hang by terminating CLI subprocess after query completes #922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… workflow hang Store the Query object reference and call close() in a finally block after the for-await loop completes. Without this, child processes spawned by the CLI (e.g., MCP servers using StdioServerTransport) keep the Node.js event loop alive, causing the GitHub Actions workflow to hang indefinitely until timeout. Fixes anthropics#865 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #865
When the Claude Code action completes, spawned MCP server processes (started by the CLI via
--mcp-config) are not terminated, causing the GitHub Actions workflow to hang indefinitely until timeout or manual cancellation.Root cause: The
query()function returns aQueryobject that extendsAsyncGeneratorand has aclose()method documented as:The current code iterates the query with
for awaitbut never callsclose(). When the async generator completes naturally, the underlying CLI process and its child MCP servers (which useStdioServerTransportand block on stdin forever) are not terminated, keeping the Node.js event loop alive.Fix: Store the
Queryobject reference and callclose()in afinallyblock after consuming the async generator.Test plan
🤖 Generated with Claude Code