fix: show error result in sanitized SDK output #917
+87
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
resultfield in sanitized SDK output whenis_erroris truesanitizeSdkOutputfor testability and adds 5 unit testsProblem
When a Claude SDK execution fails (e.g., invalid model ID, API errors), the
sanitizeSdkOutputfunction strips theresultfield from the output. This hides the actual error message, leaving users with only an opaque "process exited with code 1" and minified code context.Users see:
{"type": "result", "is_error": true, "duration_ms": 230}Instead of:
{"type": "result", "is_error": true, "result": "API Error: 404 model not found", "duration_ms": 230}Changes
base-action/src/run-claude-sdk.ts: Conditionally spreadresultwhenis_erroris true, with"result" in resultMsgtype guard for theSDKResultSuccess/SDKResultErroruniontest/sanitize-sdk-output.test.ts: 5 tests covering error result inclusion, success result omission, init messages, and message suppressionTest plan
Fixes #880