fix: make trigger_phrase matching case-insensitive #915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the 'i' flag to all four RegExp constructions in checkContainsTrigger so that trigger phrases like "@claude" also match "@claude", "@claude", etc. This fixes a confusing UX issue where iOS autocorrect capitalizes "@claude" to "@claude", causing GitHub's case-insensitive workflow `if` guard to run the action but the action's internal trigger check to silently reject it. Fixes anthropics#910 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
i(case-insensitive) flag to all fourRegExpconstructions incheckContainsTrigger@claudeto@ClaudeProblem
The
trigger_phraseregex was constructed without theiflag, making matching case-sensitive. GitHub's workflow-levelcontains()guard is case-insensitive, so the workflow would run but the action's internal check would silently reject the trigger — a confusing UX gap.Changes
src/github/validation/trigger.ts: Added"i"flag to all 4new RegExp()callstest/trigger-validation.test.ts: Addedcase-insensitive trigger matchingdescribe block with tests for@Claude,@CLAUDE, and@cLaUdEvariantsTest plan
bun test test/trigger-validation.test.ts)bun run typecheck)bun run format:check)Fixes #910