refactor(@angular/build): Expose codeBundleCache to buildApplicationInternal#32527
Open
Aukevanoost wants to merge 1 commit intoangular:mainfrom
Open
refactor(@angular/build): Expose codeBundleCache to buildApplicationInternal#32527Aukevanoost wants to merge 1 commit intoangular:mainfrom
Aukevanoost wants to merge 1 commit intoangular:mainfrom
Conversation
Exposes the codeBundle cache used in executeBuild to allow for performant multi-builder setups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First off, thanks for having a look at this!
This PR exposes the
codeBundleCacheused in executeBuild part of thebuildApplicationInternalto allow for performant multi-builder setups (because they can share the TS cache).PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Right now the
SourceFileCacheis initialized locally in theexecuteBuild()function.Issue Number: N/A
What is the new behavior?
The
SourceFileCacheis now part of theInternalOptions, allowing tools that use this builder to (optionally) provide a shared cache that can be re-used over multiple builds. As fallback it will create the default cache object.Does this PR introduce a breaking change?
Other information
We (native-federation) need this feature to speed up our builder. This way we can share the cache between the ESBuild plugin and main builder which decreases our build time drastically:
If interested, find the changes on our end here (it's a proof-of-concept): https://github.com/native-federation/angular-adapter/pull/4/changes#diff-6508a5b483eb2d55fd58361931d864832b5ba20178c796d07be21f9e8ac327ae