changed instructions for adding sqlite dependency in Android#319
changed instructions for adding sqlite dependency in Android#319martinogg wants to merge 1 commit intoandpor:masterfrom
Conversation
|
@martinogg is this related to issue with the newest react-native version 0.58? Because I'm not able to use sqlite-storage with or without your change :/ any advice? I tried all the three options,, compile, implementation and your change. Only implementation got me through this error but then some other weird errors did show up... |
|
I tried to re-create the issue you mentioned locally by creating a new empty RN project (0.58.3) then adding in react-native-sqlite-storage using the instructions in the readme. Don't see the error or warning about com.android.support:support-v4 though I did notice in app/build.gradle is using
might be something worth checking |
|
Also created a new RN Project (0.58.4) and could reproduce the error right away. |
|
Created a pull request which fixed the issue for me and kinda invalidates this pull request: #324 |
|
@martinogg @DavidKuennen Is this PR still relevant? Please check and help to resolve the conflict. Please check against latest 5.0.0 release |
|
@DavidKuennen David I merged your PR and released it. So I assume this PR can be declined ? |
required to build on the latest version of Android Studio