fix(numberfield): preserve validation errors on blur when value unchanged #9629
+42
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a NumberField has validation errors (e.g., from Form
validationErrorsprop), focusing and then blurring the field without changing its value would incorrectly reset the validation state, removing thedata-invalidattribute.Changes
In
useNumberField.ts, theonBlurhandler now checks if the input value has actually changed from the state'sinputValuebefore callingcommitAndAnnounce(). This preventscommit()from being called (and thuscommitValidation()from resetting the validation state) when the user simply focuses and blurs without editing.Reproduction
From issue #9444:
Testing
Added a test case that verifies validation errors are preserved when focusing and blurring without changing the value.
All existing NumberField tests pass.
Fixes #9444