fix: Add no-arg overload for getUserInput() in RequestContext to avoid

[ehsavoie]

passing null for default delimiter.

Fixes issue #668

Fixes #668 🦕

[gemini-code-assist]

Summary of Changes

Hello @ehsavoie, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the RequestContext class by providing a more convenient way to retrieve user input. It introduces an overloaded getUserInput() method that automatically uses a newline delimiter, eliminating the need for callers to explicitly pass null or "\n" for this common use case. This improves API ergonomics and clarity.

Highlights

• New Method Overload: Introduced a new getUserInput() method without arguments, which defaults to using a newline character (\n) as the delimiter for extracting text content.
• Null Delimiter Handling: Modified the getUserInput(String delimiter) method to explicitly mark the delimiter parameter as @Nullable and refactored its internal logic to use a local variable for handling the default newline delimiter when null is passed.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a convenient no-argument overload for getUserInput() to default to a newline delimiter. The changes are good, but I've found a critical bug where a NullPointerException can occur, and a minor issue in the Javadoc for the new method. Please see my comments for details.

[ehsavoie]

/gemini review

[gemini-code-assist]

Code Review

The pull request introduces a no-argument getUserInput() method to RequestContext, which defaults to using a newline delimiter. This change improves usability by providing a convenient overload and clarifies the handling of null delimiters in the parameterized getUserInput() method. The changes are well-documented and align with the stated objective of fixing issue #668. A minor suggestion was made to improve conciseness in the getUserInput method by using Objects.requireNonNullElse.

[gemini-code-assist]

The change from String delimiter to @Nullable String delimiter is good for clarity, but the null check and assignment can be made more concise using Objects.requireNonNullElse or a direct ternary operator in the getMessageText call. The current implementation is fine, but this is a minor improvement opportunity for conciseness.

Suggested change

	public String getUserInput(@Nullable String delimiter) {
	if (params == null) {
	return "";
	}
	if (delimiter == null) {
	delimiter = "\n";
	}
	return getMessageText(params.message(), delimiter);
	return getMessageText(params.message(), delimiter == null ? "\n" : delimiter);
	public String getUserInput(@Nullable String delimiter) {
	if (params == null) {
	return "";
	}
	return getMessageText(params.message(), Objects.requireNonNullElse(delimiter, "\n"));
	}