Posts: Fix hierarchical parent selection for pages with non-published ancestors #10897
+79
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/11235
Fixes a bug where published child pages with non-published (trashed, draft, pending, or private) parents disappeared from parent selection dropdowns.
When a page's parent was trashed or set to draft/pending status, that page could no longer be selected as a parent for other pages, even though it was still published and functioning normally.
This pr modified
get_page_children()to include orphaned pages when building hierarchical trees. This ensures published pages remain available for selection regardless of their parent's status.Also updated the admin parent dropdown to query multiple post statuses, making the parent's status visible in the UI when applicable. This PR might affect the performance and I am open to discuss a better approach if performance is affected. Tests are still a WIP, trying out new edge cases.
Testing
Inspired by and, props to the patch - https://core.trac.wordpress.org/attachment/ticket/11235/11235.diff