Skip to content

Conversation

@manishdhorepatil-art
Copy link

Fixes a deprecated JavaScript usage in the WordPress admin.

The code in wp-admin/js/theme.js was using wp.updates.l10n.updating, which has been deprecated since WordPress 5.5. This PR replaces it with the recommended wp.i18n.__() function.

Testing Instructions

Go to Dashboard → Updates or Appearance → Themes

Trigger a theme update

Confirm:

The text “Updating...” appears correctly

No deprecation notice appears in the browser console

Trac Ticket

Fixes: https://core.trac.wordpress.org/ticket/64619

   Replaces deprecated wp.updates.l10n.updating with wp.i18n.__( 'Updating...' ) in theme.js to resolve deprecation notice.

   Props: [Your WordPress.org username]
   Fixes #64619
@github-actions
Copy link

github-actions bot commented Feb 10, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props manishxdp, westonruter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@westonruter
Copy link
Member

I see there are quite a few reads of the l10n object as well. Should those not be updated as well?

@westonruter
Copy link
Member

There is a seeming duplicate PR opened at the same time: #10895. Should this be close in favor of that, or the other way around?

@manishdhorepatil-art
Copy link
Author

manishdhorepatil-art commented Feb 11, 2026

Thanks for the review, @westonruter.
I checked theme.js and found that line 1280 already uses wp.i18n.__('Updating...') instead of wp.updates.l10n.updating. I didn't find other direct references to wp.updates.l10n in this file.
Could you point to the specific instances you're seeing? I can:
Check other files if they're outside theme.js

@westonruter
Copy link
Member

westonruter commented Feb 11, 2026

Here:

.append( $.parseHTML( '<label for="wp-filter-search-input">' + l10n.search + '</label>' ) )

$button.attr({ 'aria-expanded': 'false', 'aria-label': l10n.expandSidebar });
} else {
$button.attr({ 'aria-expanded': 'true', 'aria-label': l10n.collapseSidebar });

And so on.

@manishdhorepatil-art
Copy link
Author

@westonruter Could you please checknow added nessary changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants