-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Fix: Replace deprecated wp.updates.l10n.updating with wp.i18n.__ #10896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Fix: Replace deprecated wp.updates.l10n.updating with wp.i18n.__ #10896
Conversation
Replaces deprecated wp.updates.l10n.updating with wp.i18n.__( 'Updating...' ) in theme.js to resolve deprecation notice. Props: [Your WordPress.org username] Fixes #64619
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
I see there are quite a few reads of the |
|
There is a seeming duplicate PR opened at the same time: #10895. Should this be close in favor of that, or the other way around? |
|
Thanks for the review, @westonruter. |
|
Here:
wordpress-develop/src/js/_enqueues/wp/theme.js Lines 976 to 978 in f9275df
And so on. |
…/manishdhorepatil-art/wordpress-develop into 64619-deprecated-wp-updates-l10n
|
@westonruter Could you please checknow added nessary changes |
Fixes a deprecated JavaScript usage in the WordPress admin.
The code in wp-admin/js/theme.js was using wp.updates.l10n.updating, which has been deprecated since WordPress 5.5. This PR replaces it with the recommended wp.i18n.__() function.
Testing Instructions
Go to Dashboard → Updates or Appearance → Themes
Trigger a theme update
Confirm:
The text “Updating...” appears correctly
No deprecation notice appears in the browser console
Trac Ticket
Fixes: https://core.trac.wordpress.org/ticket/64619