Update FindMax to use Math.max for maximum calculation#7262
Open
MuhammadMuneebMubashar wants to merge 6 commits intoTheAlgorithms:masterfrom
Open
Update FindMax to use Math.max for maximum calculation#7262MuhammadMuneebMubashar wants to merge 6 commits intoTheAlgorithms:masterfrom
MuhammadMuneebMubashar wants to merge 6 commits intoTheAlgorithms:masterfrom
Conversation
Fix logic to find maximum value in the array.
MuhammadMuneebMubashar
requested review from
DenizAltunkapan,
alxkm and
yanglbme
as code owners
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7262 +/- ##
============================================
+ Coverage 79.26% 79.32% +0.06%
- Complexity 6984 6991 +7
============================================
Files 781 781
Lines 22958 22956 -2
Branches 4510 4508 -2
============================================
+ Hits 18197 18210 +13
+ Misses 4034 4020 -14
+ Partials 727 726 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Refactored the FindMax class by simplifying the constructor and optimizing the findMax method's checks and loop.
Contributor
Author
MuhammadMuneebMubashar
left a comment
MuhammadMuneebMubashar
left a comment
There was a problem hiding this comment.
updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix logic to find maximum value in the array.
clang-format -i --style=file path/to/your/file.java