fix(Highlighter): auto toggle single item#693
Open
Kurtil wants to merge 1 commit intoThatOpen:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current Highlighter cannot auto toggle a single item. This is because the previous selection is cleared before the auto toggle picking logic is done.
Steps to reproduce:
-> Nothing change, the item is still highlighted
Workaround: pressing the
multiplekey (ctrl on the example) let the item be deselected. This is because themultipleconfig is then interpreted as notremovePrevious, preventing the clear to be done.Solution:
If picking and auto toggle are
true, prevent clearing the selection if the new requested selection is the same as the current one. Letting the code take the same path as ifmultipleis pressed, deselecting the item 🎉 .Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following:
feat(examples): add hello-world example).fixes #123).