fix(form-core): exclude undefined from errors type to match runtime behavior #2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ehavior The runtime implementation filters out undefined values from errorMap, but the type definition included undefined in the union types. This caused type errors when accessing error properties without undefined checks. Wrap the errors type union with Exclude<..., undefined> in both FormApi and FieldApi to align the type system with the actual runtime behavior. Closes TanStack#2022
🦋 Changeset detectedLatest commit: ad62fd9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Changes
The runtime implementation filters out undefined values from errorMap, but the type definition included undefined in the union types. This caused type errors when accessing error properties without undefined checks.
Wrap the errors type union with Exclude<..., undefined> in both FormApi and FieldApi to align the type system with the actual runtime behavior.
Closes #2022
✅ Checklist
pnpm test:pr.🚀 Release Impact