Open
Conversation
tupui
reviewed
Feb 13, 2026
Member
tupui
left a comment
tupui
left a comment
There was a problem hiding this comment.
Thanks for working on this @justushelo !
Could you add a/some test which would have been failing without these changes and now pass?
| foe : ndarray of shape (n_factors, 1) | ||
| First-order effects (also called 'main' or 'individual'). | ||
| soe : ndarray of shape (n_factors, 1) | ||
| soe_full : ndarray of shape (n_factors, 1) |
Author
There was a problem hiding this comment.
I thought it could help any future debugging to have the same variable name soe_full as it can be found in the Matlab function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed sensitivity indices SOE calculation and additionally fix decomposition logic to follow Matlab.