fix: disable single-dollar math to prevent currency symbol text corruption#11649
Draft
roomote[bot] wants to merge 1 commit intomainfrom
Draft
fix: disable single-dollar math to prevent currency symbol text corruption#11649roomote[bot] wants to merge 1 commit intomainfrom
roomote[bot] wants to merge 1 commit intomainfrom
Conversation
…ption Set singleDollarTextMath: false in remarkMath config so that single $ signs (e.g. R$, US$, $100) are not treated as inline math delimiters. Math expressions still work with $$ syntax. Fixes #11648
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #11648
Description
This PR attempts to address Issue #11648 where currency symbols (R$, US$, $100, etc.) cause text corruption in the markdown renderer. The
remark-mathplugin was treating single$as inline math delimiters, causing text between dollar signs to be parsed as LaTeX.The fix sets
singleDollarTextMath: falsein theremarkMathplugin config, as suggested by @diovannesn in the issue discussion. This is a 1-line config change that:$from being treated as math delimiters$$...$$syntax for both inline and display mathThe trade-off is that inline math now requires
$$x$$instead of$x$, but$$x$$renders as inline (not block) math, so functionality is preserved.Test Procedure
MarkdownBlock.spec.tsx:cd webview-ui && npx vitest run src/components/common/__tests__/MarkdownBlock.spec.tsxPre-Submission Checklist
Documentation Updates
Additional Notes
Feedback and guidance are welcome.
Interactively review PR in Roo Code Cloud