fix: accept empty string result in attempt_completion tool#11646
Closed
roomote[bot] wants to merge 1 commit intomainfrom
Closed
fix: accept empty string result in attempt_completion tool#11646roomote[bot] wants to merge 1 commit intomainfrom
roomote[bot] wants to merge 1 commit intomainfrom
Conversation
Change truthy check to explicit undefined check in NativeToolCallParser.ts so that empty string results are not incorrectly rejected. Fixes #11404
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11404 -- The
attempt_completiontool was incorrectly rejecting empty string results.Problem
The existing code used a truthy check (
if (!result)/if (args.result)) which treated empty strings ("") as falsy, causing valid empty-string completions to be rejected with a missing nativeArgs error.Solution
Changed the truthy check to an explicit existence check (
!== undefined) in both the streaming and finalize parse paths inNativeToolCallParser.ts.Changes
src/core/assistant-message/NativeToolCallParser.ts: Two truthy checks changed to!== undefinedsrc/core/assistant-message/__tests__/NativeToolCallParser.spec.ts: Three regression tests addedTesting
View task on Roo Code Cloud
Interactively review PR in Roo Code Cloud