Skip to content

Pump @eslint/js and eslint to latest #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
minggangw merged 2 commits into from
Feb 24, 2026
Merged

Pump @eslint/js and eslint to latest #1396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
212f04b
Pump @eslint/js and eslint to latest
minggangw Feb 24, 2026
4b87e3a
Fix lint error
minggangw Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/parameter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -883,7 +883,7 @@ function validValue(value, type) {
return type === ParameterType.PARAMETER_NOT_SET;
}

let result = true;
let result;
switch (type) {
case ParameterType.PARAMETER_NOT_SET:
result = !value;
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,15 +48,15 @@
"url": "git+https://github.com/RobotWebTools/rclnodejs.git"
},
"devDependencies": {
"@eslint/js": "^9.36.0",
"@eslint/js": "^10.0.1",
"@types/node": "^25.0.2",
"@typescript-eslint/eslint-plugin": "^8.18.0",
"@typescript-eslint/parser": "^8.18.0",
Comment on lines 53 to 54
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TypeScript ESLint plugin and parser at version 8.18.0 may not be compatible with ESLint v10. TypeScript ESLint v8 was designed to support ESLint v8 and v9. If ESLint v10 introduces breaking changes, you'll need to update @typescript-eslint/eslint-plugin and @typescript-eslint/parser to a version that explicitly supports ESLint v10. Please verify the peer dependency requirements and test that linting still works correctly after this update.

Suggested change
"@typescript-eslint/eslint-plugin": "^8.18.0",
"@typescript-eslint/parser": "^8.18.0",
"@typescript-eslint/eslint-plugin": "^9.0.0",
"@typescript-eslint/parser": "^9.0.0",

Copilot uses AI. Check for mistakes.
"clang-format": "^1.8.0",
"commander": "^14.0.0",
"coveralls": "^3.1.1",
"deep-equal": "^2.2.3",
"eslint": "^9.16.0",
"eslint": "^10.0.2",
"eslint-config-prettier": "^10.0.2",
"eslint-plugin-prettier": "^5.2.1",
Comment on lines 60 to 61
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify that eslint-config-prettier and eslint-plugin-prettier are compatible with ESLint v10. These plugins may have peer dependency requirements that need to be checked. Test the linting configuration after updating to ensure all plugins work correctly together.

Copilot uses AI. Check for mistakes.
"globals": "^17.0.0",
Expand Down
Loading