fix: preserve visible state in state consumer#11
Open
Des1ynY wants to merge 1 commit intoPlugFox:masterfrom
Open
fix: preserve visible state in state consumer#11Des1ynY wants to merge 1 commit intoPlugFox:masterfrom
Des1ynY wants to merge 1 commit intoPlugFox:masterfrom
Conversation
Des1ynY
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug description:
StateConsumerdropped visible state when rebuilding from outer scope.Why happened:
StateConsumerutilized_controller.stateproperty.buildWhenmethod prevents rebuilding widget internally, so whenStateConsumeris isolated everything works well and visible state is preserved. But any rebuild from outer scope (setState,ListenableBuilder, etc.) that will triggerStateConsumerrebuild, will cause visible state loss in favor of current controller state.Fix: cache visible state in _StateConsumerState and use it in
builderIDK if it was by design but caused some troubles in our project. Highly appreciate your work, we're migrating from bloc to control and it's doing great job. Thank you)