Switch RPM probes from PROBE_OFFLINE_CHROOT to PROBE_OFFLINE_OWN#2315
Open
0intro wants to merge 1 commit intoOpenSCAP:mainfrom
Open
Switch RPM probes from PROBE_OFFLINE_CHROOT to PROBE_OFFLINE_OWN#23150intro wants to merge 1 commit intoOpenSCAP:mainfrom
0intro wants to merge 1 commit intoOpenSCAP:mainfrom
Conversation
The rpminfo, rpmverifyfile, and rpmverify probes declared PROBE_OFFLINE_CHROOT mode, causing the probe framework to call chroot which requires root privileges. All three probes already had PROBE_OFFLINE_OWN handler code using rpmtsSetRootDir to point librpm at the sysroot's RPM database without chroot. Switch the offline mode to PROBE_OFFLINE_OWN so oscap-chroot scans work as an unprivileged user. Update the offline test scripts to use set_offline_chroot_dir directly, removing the chroot capability requirement.
0intro
requested review from
Mab879,
jan-cerny and
matusmarhefka
as code owners
|
Mab879
reviewed
Feb 18, 2026
Member
Mab879
left a comment
Mab879
left a comment
There was a problem hiding this comment.
Looks like we need to update tests/probes/rpm/rpmverifypackage/test_probes_rpmverifypackage_offline.sh as well to use rpm_prepare_offline_own as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rpminfo, rpmverifyfile, and rpmverify probes declared PROBE_OFFLINE_CHROOT mode, causing the probe framework to call chroot which requires root privileges. All three probes already had PROBE_OFFLINE_OWN handler code using rpmtsSetRootDir to point librpm at the sysroot's RPM database without chroot.
Switch the offline mode to PROBE_OFFLINE_OWN so oscap-chroot scans work as an unprivileged user. Update the offline test scripts to use set_offline_chroot_dir directly, removing the chroot capability requirement.