fix: correct torch.torch.int32 typo to torch.int32#1258
Open
Mr-Neutr0n wants to merge 1 commit intoOpenGVLab:mainfrom
Open
fix: correct torch.torch.int32 typo to torch.int32#1258Mr-Neutr0n wants to merge 1 commit intoOpenGVLab:mainfrom
Mr-Neutr0n wants to merge 1 commit intoOpenGVLab:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
torch.torch.int32totorch.int32ininternvl_chat/internvl/model/internlm2/modeling_internlm2.py(line 87)Details
In the
_get_unpad_datafunction, thedtypeargument totorch.cumsumis specified astorch.torch.int32. This works at runtime by accident becausetorch.torchresolves circularly back to thetorchmodule itself (i.e.,torch.torch is torchevaluates toTrue), sotorch.torch.int32ends up being the same object astorch.int32.However, this is clearly a typo and will cause failures under static type checkers (e.g., mypy, pyright) since
torch.torchis not part of the public API. This PR corrects it totorch.int32.Note that line 84 in the same function already uses the correct
torch.int32: