Open
Conversation
Update setuptools-scm tag_regex patterns to capture a/b pre-release suffixes in cuda-bindings, cuda-core, cuda-pathfinder, and cuda-python. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Member
|
I don't remember I've asked for stripping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In connection with PR #1606 I looked into how we could do test-run releases, to validate our tooling.
Main pain-point: our current
tag_regexstripsa/b/rcsuffixes, so even tags like1.2.3a1collapse to1.2.3. That makes it hard to do mainstream release test-runs.IIRC @leofang explained that we need to strip
rc, but could we not stripa/b? -- That's this PR.Assuming #1606 is merged, do we actually still need the
rcstripping, or could we go fully mainstream?