initial commit, plasma effect is rendering#1608
initial commit, plasma effect is rendering#1608rparolin wants to merge 6 commits intoNVIDIA:mainfrom
Conversation
rparolin
commented
Feb 12, 2026
rparolin
commented
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
| # (c) Unmap happens automatically when the `with` block exits. | ||
| # The PBO now belongs to OpenGL again. | ||
|
|
||
| stream.sync() |
There was a problem hiding this comment.
Should this sync be inside the above context to avoid a potential race with the unmap call making the memory available to OpenGL and triggering the barrier that ensures all the PBO values have been written.
There was a problem hiding this comment.
stream.sync() shouldn't be required as the unmap call has an implicit stream sync guaranteeing all cuda work is complete before handing the memory back to OpenGL.
There was a problem hiding this comment.
| HANDLE_RETURN( | ||
| cydriver.cuGraphicsMapResources(1, &raw, cy_stream) | ||
| ) |
There was a problem hiding this comment.
optional: you could make the unmap more reliable (and avoid the duplicated calls to cuGraphicsUnmapResources) by making this into a resource, similar to the handle.
2 participants
