Conversation
|
There is also this mysterious string that just says "Got ", which I assume gets printed into console: |
phit
left a comment
phit
left a comment
There was a problem hiding this comment.
overall really nice cleanup! I just have a couple nitpicks
| } | ||
| case AccountState::Errored: { | ||
| return tr("Errored", "Account status"); | ||
| return tr("Error", "Account status"); |
There was a problem hiding this comment.
the past tense here is intentional as the account has errored
There was a problem hiding this comment.
"Errored" is not a word that exists in formal language. You have to remember, these words have to be translated into other languages, if words are made up, the translators have to make up their own words as well, which often make even less sense than in the original. The correct form would be "Encountered an error", but there is very little space in the UI to fit such a long string.
There was a problem hiding this comment.
errored is very much a real adjective https://en.wiktionary.org/wiki/errored
now you can argue all you want about formal language, but I think that ship has sailed a long time ago in terms of real world usage and at least in German, errored translates perfectly to the adjective fehlerhaft
The correct form would be "Encountered an error"
I too read this https://english.stackexchange.com/questions/3059/is-errored-correct-usage
| AccountTaskState::STATE_FAILED_SOFT, | ||
| tr("This Microsoft account does not have an XBox Live profile. Buy the game on %1 first.") | ||
| .arg("<a href=\"https://www.minecraft.net/en-us/store/minecraft-java-edition\">minecraft.net</a>") | ||
| tr("This Microsoft account does not have an XBox Live profile. Purchasing the game on <a href=\"https://www.minecraft.net/en-us/store/minecraft-java-edition\">minecraft.net</a> is required.") |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| emit finished( | ||
| AccountTaskState::STATE_FAILED_SOFT, | ||
| tr("XBox Live is not available in your country. You've been blocked.") | ||
| tr("XBox Live is not available in this country. The provided account has been blocked.") |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| { | ||
| // This is the "Vanilla" modpack, excluded by the search code | ||
| emit failed(tr("Unable to find a \"version.json\"!")); | ||
| emit failed(tr("Unable to find \"version.json\"!")); |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
2 participants
While localizing the launcher to Polish, I have encountered some issues in the source strings
%1) not being used/en-us/to/pl-pl/)This PR fixes some of the strings I had issues with