Skip to content

fix: damage reputation loss is now proportional rather than constant#730

Open
BenjaminAmos wants to merge 1 commit intoMovingBlocks:developfrom
BenjaminAmos:fix/damage-reputation-loss
Open

fix: damage reputation loss is now proportional rather than constant#730
BenjaminAmos wants to merge 1 commit intoMovingBlocks:developfrom
BenjaminAmos:fix/damage-reputation-loss

Conversation

@BenjaminAmos
Copy link
Contributor

Description

This pull request changes reputation loss due to damage to be proportional to the damage inflicted, rather than constant per-hit. It also changes the damage handling code to take into account the instigator of the damage, removing a previous constraint where the projectile code directly managed reputation loss, which was a poor place to handle this in.

It also implements a fixed penalty reputation loss when a ship is destroyed, which was previously referenced in the code but unimplemented.

Testing

  • Start a new game with the Loaded Imperial Large ship
  • Fire on the starting station until it starts firing back.
  • Destroy a few of the guards
  • Fly around and verify that other Imperial faction ships are now hostile to you

Notes

This fixes #729.

@BenjaminAmos BenjaminAmos force-pushed the fix/damage-reputation-loss branch from c125fdd to 9849476 Compare February 14, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Make faction reputation decrease based on damage instead of hit count

1 participant