fix: damage reputation loss is now proportional rather than constant#730
Open
BenjaminAmos wants to merge 1 commit intoMovingBlocks:developfrom
Open
fix: damage reputation loss is now proportional rather than constant#730BenjaminAmos wants to merge 1 commit intoMovingBlocks:developfrom
BenjaminAmos wants to merge 1 commit intoMovingBlocks:developfrom
Conversation
c125fdd to
9849476
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request changes reputation loss due to damage to be proportional to the damage inflicted, rather than constant per-hit. It also changes the damage handling code to take into account the instigator of the damage, removing a previous constraint where the projectile code directly managed reputation loss, which was a poor place to handle this in.
It also implements a fixed penalty reputation loss when a ship is destroyed, which was previously referenced in the code but unimplemented.
Testing
Loaded Imperial LargeshipImperialfaction ships are now hostile to youNotes
This fixes #729.