Fix domain decomposition overwriting muscl_order

[sbryngelson]

User description

Summary

• The IGR conditional block in the domain decomposition routine had an else branch that unconditionally set recon_order = weno_order
• This overwrote the correct muscl_order value that was set by the recon_type check earlier in the function
• Fix removes the else branch so recon_order is only overridden when IGR is actually active

Test plan

• Verify MUSCL reconstruction order is preserved through domain decomposition
• May need golden file regeneration for MUSCL-based test cases

🤖 Generated with Claude Code

---

CodeAnt-AI Description

Preserve MUSCL reconstruction order during domain decomposition

What Changed

• Removed an unconditional reset to WENO in an early IGR check so the reconstruction order set by the recon_type selection (e.g., MUSCL) is no longer overwritten when IGR is inactive
• IGR still forces its own reconstruction order when active; when IGR is off, the previously chosen reconstruction (MUSCL or other) is retained
• Domain decomposition no longer causes unexpected switches to WENO in normal (non-IGR) runs

Impact

✅ Preserves MUSCL during domain decomposition
✅ Fewer unexpected reconstruction resets
✅ More consistent reconstruction order across processors

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

[cubic-dev-ai]

No issues found across 1 file

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.05%. Comparing base (d048c4b) to head (e5e82f9).
⚠️ Report is 15 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1229      +/-   ##
==========================================
- Coverage   44.07%   44.05%   -0.02%     
==========================================
  Files          70       70              
  Lines       20431    20497      +66     
  Branches     1974     1991      +17     
==========================================
+ Hits         9004     9029      +25     
- Misses      10291    10329      +38     
- Partials     1136     1139       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.