Skip to content

Remove debug print left in QBMM production code#1226

Merged
sbryngelson merged 2 commits intoMFlowCode:masterfrom
sbryngelson:fix/qbmm-debug-print
Feb 22, 2026
Merged

Remove debug print left in QBMM production code#1226
sbryngelson merged 2 commits intoMFlowCode:masterfrom
sbryngelson:fix/qbmm-debug-print

Conversation

@sbryngelson
Copy link
Member

@sbryngelson sbryngelson commented Feb 21, 2026

User description

Summary

  • Removed a print *, 'In convert, nbub:' statement that was left in the prim-to-cons conversion path
  • This print fires every time step at cell (0,0,0), polluting stdout in QBMM production runs

Test plan

  • No functional change; verify QBMM test cases still pass
  • No golden file changes expected

🤖 Generated with Claude Code


CodeAnt-AI Description

Remove leftover debug print that emitted nbub at cell (0,0,0) every timestep

What Changed

  • Deleted a diagnostic print that printed "In convert, nbub: " for cell (0,0,0) on every timestep
  • Runs no longer emit that per-timestep message to stdout; numerical results and outputs are unchanged

Impact

✅ Fewer noisy logs during QBMM runs
✅ Cleaner stdout for automated log collection and monitoring
✅ Unchanged simulation outputs

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Summary by CodeRabbit

  • Chores
    • Removed diagnostic output from internal processing.

Remove a diagnostic print statement that was left in the prim-to-cons
conversion path for QBMM bubbles. This print fires every time step
at cell (0,0,0), polluting stdout in production runs.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings February 21, 2026 22:57
@codeant-ai

This comment has been minimized.

@coderabbitai

This comment has been minimized.

@codeant-ai

This comment has been minimized.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes an unconditional debug print statement from the QBMM (Quadrature-Based Method of Moments) bubble physics code in the primitive-to-conservative variable conversion routine. The print statement was firing every timestep at cell (0,0,0), polluting stdout in production runs.

Changes:

  • Removed unconditional debug print statement from QBMM nbub calculation in m_variables_conversion.fpp

@codecov
Copy link

codecov bot commented Feb 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.05%. Comparing base (84c46e0) to head (d3f6337).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1226   +/-   ##
=======================================
  Coverage   44.05%   44.05%           
=======================================
  Files          70       70           
  Lines       20498    20496    -2     
  Branches     1990     1989    -1     
=======================================
  Hits         9030     9030           
+ Misses      10329    10328    -1     
+ Partials     1139     1138    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codeant-ai
Copy link
Contributor

codeant-ai bot commented Feb 22, 2026

CodeAnt AI is running Incremental review


Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@sbryngelson sbryngelson merged commit df28255 into MFlowCode:master Feb 22, 2026
22 of 28 checks passed
@codeant-ai
Copy link
Contributor

codeant-ai bot commented Feb 22, 2026

CodeAnt AI Incremental review completed.

@sbryngelson sbryngelson deleted the fix/qbmm-debug-print branch February 22, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants