Remove debug print left in QBMM production code#1226
Remove debug print left in QBMM production code#1226sbryngelson merged 2 commits intoMFlowCode:masterfrom
Conversation
Remove a diagnostic print statement that was left in the prim-to-cons conversion path for QBMM bubbles. This print fires every time step at cell (0,0,0), polluting stdout in production runs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull request overview
This pull request removes an unconditional debug print statement from the QBMM (Quadrature-Based Method of Moments) bubble physics code in the primitive-to-conservative variable conversion routine. The print statement was firing every timestep at cell (0,0,0), polluting stdout in production runs.
Changes:
- Removed unconditional debug print statement from QBMM nbub calculation in
m_variables_conversion.fpp
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1226 +/- ##
=======================================
Coverage 44.05% 44.05%
=======================================
Files 70 70
Lines 20498 20496 -2
Branches 1990 1989 -1
=======================================
Hits 9030 9030
+ Misses 10329 10328 -1
+ Partials 1139 1138 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
CodeAnt AI is running Incremental review Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
CodeAnt AI Incremental review completed. |
User description
Summary
print *, 'In convert, nbub:'statement that was left in the prim-to-cons conversion pathTest plan
🤖 Generated with Claude Code
CodeAnt-AI Description
Remove leftover debug print that emitted nbub at cell (0,0,0) every timestep
What Changed
Impact
✅ Fewer noisy logs during QBMM runs✅ Cleaner stdout for automated log collection and monitoring✅ Unchanged simulation outputs💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.
Summary by CodeRabbit