Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
I am still uncertain, this will protect the MASQ Foundation network, because if someone want's to set rate-pack below the limit, it is just one change and cargo build away from doing so and network does not even aknowledge this. I woud like to propose: make an debut_handler rule, that if the debuting node is in standard, or originate-only mode, and have rate pack below (or above) the limits, his debut is dropped on the flor
|
Hey @dnwiebe @czarte - I agree with @czarte comments to add this additional checking in the handlers to ensure Nodes don't have rate-packs outside of the defined limits now, and can be done without too much additional work. This will cover older versions of Node joining network with rates outside the hard-coded limits |
| @@ -0,0 +1,67 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| @@ -1412,6 +1854,58 @@ impl GossipAcceptorReal { | |||
| debut_target_node_addr.clone(), | |||
| )) | |||
| } | |||
|
|
|||
| fn validate_new_version( | |||
There was a problem hiding this comment.
hint: what about name: validate_standard_nodes_requirements
reason: in gossip we refering with version to NeighborhoodDatabase version, so it seems bit confusing name for me here
There was a problem hiding this comment.
I decided on validate_incoming_agr(); I think that's pretty clear.
| let (mut valid_agrs, mut bans) = so_far; | ||
| if &agr.inner.public_key == database.root_key() { | ||
| // Shouldn't ever happen; but an evil Node could try it | ||
| // valid_agrs.push(agr); |
| Qualification::Malformed(malefactor) => { | ||
| let (public_key_opt, ip_address_opt, earning_wallet_opt) = | ||
| match agrs.iter().find(|agr| { | ||
| agr.node_addr_opt.as_ref().map(|na| na.ip_addr()) |
There was a problem hiding this comment.
Note: I would like to see the tests of malefactor claiming our own ip, that this ip is not comming in here
There was a problem hiding this comment.
In method extract_malefactors it looks like we are using agr ip in case we malefactor him for claiming our own IP
There was a problem hiding this comment.
I don't understand this issue. I'll ask you about it.
Further elaboration: we talked about it and decided that it could be ignored. However, it led us to a piece of dead code that needs to be driven out.
| let (gossip, gossip_source) = make_introduction(2345, 3456); | ||
| let dest_root = make_node_record(7878, true); | ||
| let mut dest_db = db_from_node(&dest_root); | ||
| // These don't count because they're half-only neighbors. Will they be ignored? |
There was a problem hiding this comment.
Due to Ban and Log message those are ignored. shout the question stay?
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on March 14
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| </map> | ||
| </option> | ||
| </component> | ||
| </project> No newline at end of file |
There was a problem hiding this comment.
IDE config file committed to repository
Low Severity
The .idea/SweepConfig.xml file appears to be a user-specific IDE configuration for the Sweep AI assistant plugin, containing BYOK provider configs and model names. This is unrelated to the PR's stated purpose of adding rate-pack value limits. While some .idea files are tracked in this repo, IDE plugin configurations with specific model versions (e.g., claude-sonnet-4-5-20250929, gpt-5-2025-08-07) are typically developer-specific and can cause unnecessary merge conflicts.
3 participants
Note
Medium Risk
Introduces a new persisted config value with a DB migration and parsing/validation logic; mistakes could break startup/migration or mis-handle rate configuration, but scope is mostly configuration + tests.
Overview
Adds persisted rate-pack bounds via new
rate_pack_limitsconfig, including schema bump toCURRENT_SCHEMA_VERSION = 12and a new11->12DB migration to backfill the value on existing databases.Extends configuration access with
PersistentConfiguration::rate_pack_limits()(regex-validated parsing + ordering checks) and ensures defaults are set in both the DB initializer and the daemon’s null config DAO; also updates various setup/config test fixtures to use largerrate-packvalues.Separately improves robustness/diagnostics: accountant logging now includes computed total charges (and centralizes charge calculation), docker network creation in multinode tests retries on failure, and several multinode tests are made less flaky (timeouts/sleeps, different test host paths, clearer payable/receivable mismatch reporting).
Written by Cursor Bugbot for commit fd2f6f2. This will update automatically on new commits. Configure here.