canterp: fix parsing of ORIENT_SPINDLE#3825
Merged
andypugh merged 1 commit intoLinuxCNC:2.9from Feb 24, 2026
Merged
Conversation
smoe
added
bug
for-discussion-only
Contributor
|
Correct, the use of |
smoe
removed
for-discussion-only
smoe
force-pushed
the
fix_canterp_spindle_orientation
branch
from
811354b to
2a72933
Compare
Collaborator
Author
|
Thank you, @BsAtHome . Backported to the 2.9 branch. Feels a bit like this should also go into 2.8 and 2.7. |
Collaborator
|
It could maybe be backported to 2.8 (2.7 never got the multispindle update) but I don't anticipate any further 2.7 or 2.8 releases, and I rather doubt that anyone has ever used canterp in anger, especially not with multiple spindles. It really only exists as a least-effort alternative interpreter to check pluggable interpreters, as far as I can tell. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did not feel like trusting my eyes, but while the parser is parsing into d1, the value passed is that of d2, with the value of d1 lost. This makes no sense, right?
Can anyone confirm that this patch is correct? I would then prepare the same against 2.9.