Fix printing hm2_modbus messages at startup#3824
Open
BsAtHome wants to merge 1 commit intoLinuxCNC:masterfrom
Open
Fix printing hm2_modbus messages at startup#3824BsAtHome wants to merge 1 commit intoLinuxCNC:masterfrom
BsAtHome wants to merge 1 commit intoLinuxCNC:masterfrom
Conversation
Collaborator
|
Should this also go into 2.9? |
Contributor
Author
Probably. But I can't test-run 2.9 branch because I haven't backported the tcl/tk9 stuff. That said, the same patch should work for both branches. |
Collaborator
|
I would guess that if it passes CI as a 2.9 fix it's probably good? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix printing errors/warnings/messages at startup by using rtapi_print() instead of rtapi_print_msg(). The latter does not actually output anything in the rtapi_app_main() function.
This fixes a problem mentioned in #3822 of not finding the PktUART port and hm2_modus not telling the user of the issue.