Cmake interface update#57
Conversation
|
@phcerdan Are you still maintaining this module along with the forked proxTV code? |
|
@blowekamp well, It has been a while, but I can help. The fork proxTV is indeed under my username. Do we need to update the proxTV fork as well? |
Yes. As mentioned in the PR message: I had some local changes that seem to work with a this remote build in the ITK repo, but there are a few other usages that need to be checked. I was not able to follow all the installation and exporting of targets and files going on. Some of it looks off to me. |
|
Got it. How can I help? |
What is the current status of your proxTV fork with upstream? Look's like upstream is in active. Maybe we can be aggressive with deleting unneeded install code, as we don't expect upstream changes? Also it looks like the current build are not working, maybe not up-to date? I am not too familiar with all the remote python infrastructure. Would you be available to look at that? P.S. I am also testing this with wrapping in SimpleITK. |
Recent changes to ITK have been made to use CMake interfaces over raw libraries and files, along with adding the ITK namespace to targets: See InsightSoftwareConsortium/ITK#5721 Refactored installation of proxTV so that it is no longer done by the fetched project but controlled through the ITK module macros as a target. Note there is still some "odd" behavior with the Eigen3 dependency when provided by ITK it is not a target provided by idea, but needs a find_package done to locate. This change consistently uses the proxTV namespace for compatibility between uses of the proxTV.
blowekamp
force-pushed
the
cmake_interface_update
branch
from
17ba86f to
01e56fe
Compare
2 participants
BUG: Use correct variable for linking libraries for tests
BUG: Address issues related to ITK update to modern interfaces
Recent changes to ITK have been made to use CMake interfaces over raw libraries and files, along with adding the ITK namespace to targets:
See InsightSoftwareConsortium/ITK#5721
This change consistently uses the proxTV namespace for compatibility between uses of the proxTV.
There are additional problems detected in the proxTV library including duplicate exporting of targets which cause configuration issues. Additionally, installation paths for all libraries and exports needs to be reviewed and verified for the correct importing of proxTV::proxTV.