Update node version in github actions#12
Update node version in github actions#12rflamand wants to merge 6 commits intoImagingDataCommons:masterfrom
Conversation
|
The job seems to fail on the npm dry run. Im not 100% sure on the specifics of the dry run, ill try to take a look next week! |
|
Apparently, dry run also checks the version (so it does everything except the actual publishing, which makes sense). 0.2.2 is already published in this case, so it fails. Consequently, we'll need to ensure that the first PR/commit after every release is the version bump (though we'll immediately see it as the checks will fail). We could also remove the dry run check from normal checks. Doing so would allow us to choose the next version number right before the release (and not right after the previous one). It's whatever you feel most comfortable with @fedorov. |
I am not sure I understand! But I think it's ok to remove dry run. Let me know when this PR is ready and I will merge! |
Alright I'll remove the dry run. The main benefit from this is that we can choose when we update the version in |
|
@fedorov I've pushed the patch, dry run has now been removed. I've also restored the version as the version bump is no longer needed for the job to complete. |
I have updated the node version in the github action scripts to the latest active LTS version (24.13.1). This comes with a newer npm version, which allows us to use the open id infrastructure when publishing to npm.
While doing this, I've also
git+in front)