add GeneralUpdate.Drivelution by JusterZhu · Pull Request #138 · GeneralLibrary/GeneralUpdate

JusterZhu · 2026-02-08T16:34:28Z

No description provided.

JusterZhu · 2026-02-08T16:40:21Z

@copilot Please fully understand the content submitted in this PR and check if there are any areas in the code that need improvement. If not, generate a README/usage instruction Markdown document and place it in the doc directory.

Copilot · 2026-02-08T16:40:28Z

@JusterZhu I've opened a new pull request, #139, to work on those changes. Once the pull request is ready, I'll request review from you.

* Initial plan * Add comprehensive README documentation for GeneralUpdate.Drivelution Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com>

JusterZhu · 2026-02-08T16:57:28Z

@copilot Write test cases based on the core content of GeneralUpdate.Drivelution.

Copilot · 2026-02-08T16:57:35Z

@JusterZhu I've opened a new pull request, #140, to work on those changes. Once the pull request is ready, I'll request review from you.

* Initial plan * Add comprehensive test cases for GeneralUpdate.Drivelution Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com> * Address code review feedback: improve test quality and cleanup Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com>

JusterZhu · 2026-02-08T17:08:08Z

@copilot Replace all instances of "DriverUpdate" with "Drivelution".

Copilot · 2026-02-08T17:08:15Z

@JusterZhu I've opened a new pull request, #141, to work on those changes. Once the pull request is ready, I'll request review from you.

* Initial plan * Replace all instances of DriverUpdate with Drivelution Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com> * Update error code prefixes from DU_ to DR_ Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com>

JusterZhu · 2026-02-09T08:59:54Z

@JusterZhu I've opened a new pull request, #141, to work on those changes. Once the pull request is ready, I'll request review from you.

The filename has not been modified.

JusterZhu · 2026-02-09T09:22:13Z

@copilot Add a method in GeneralDrivelution.cs to read the driver information from the local directory and return a list of DriverInfo to the caller. If this has already been implemented, please let me know where the code is located.

Copilot · 2026-02-09T09:22:23Z

@JusterZhu I've opened a new pull request, #142, to work on those changes. Once the pull request is ready, I'll request review from you.

* Initial plan * Add GetDriversFromDirectoryAsync method to read driver information from local directory Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com> * Add tests for GetDriversFromDirectoryAsync method Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com> * Fix security issues: prevent command injection and improve certificate parsing Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com> * Translate all Chinese annotations to English Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com>

Copilot

Pull request overview

Adds a new GeneralUpdate.Drivelution .NET 8 library intended to provide cross-platform (Windows/Linux; macOS placeholder) driver update workflows including validation, backup/rollback, logging, and supporting utilities, plus a new xUnit test project and documentation.

Changes:

Introduces GeneralUpdate.Drivelution project with abstractions (models/interfaces/exceptions) and factory/entry-point APIs.
Adds Windows/Linux implementations (permission checks, validation helpers, backup, install scaffolding, driver discovery) and shared utilities (hashing, SemVer compare, compatibility, restart helper).
Adds DrivelutionTest test project and a large usage/feature documentation page.

Reviewed changes

Copilot reviewed 38 out of 38 changed files in this pull request and generated 17 comments.

Show a summary per file

File	Description
src/c#/GeneralUpdate.sln	Adds `GeneralUpdate.Drivelution` project to the solution.
src/c#/GeneralUpdate.Drivelution/GeneralUpdate.Drivelution.csproj	New library project definition (net8.0 + Serilog deps + trimming/AOT flags).
src/c#/GeneralUpdate.Drivelution/GeneralDrivelution.cs	Public static entry point + convenience APIs + platform info wrapper.
src/c#/GeneralUpdate.Drivelution/Core/DriverUpdaterFactory.cs	Platform detection and creation of OS-specific implementations.
src/c#/GeneralUpdate.Drivelution/Core/Logging/LoggerConfigurator.cs	Serilog configuration factory based on options.
src/c#/GeneralUpdate.Drivelution/Core/Utilities/VersionComparer.cs	SemVer 2.0 parsing/comparison helper.
src/c#/GeneralUpdate.Drivelution/Core/Utilities/RestartHelper.cs	Cross-platform restart helper (shutdown invocation + prompt stub).
src/c#/GeneralUpdate.Drivelution/Core/Utilities/HashValidator.cs	Async file hashing and hash validation utility.
src/c#/GeneralUpdate.Drivelution/Core/Utilities/CompatibilityChecker.cs	OS/arch compatibility checks + report model.
src/c#/GeneralUpdate.Drivelution/Abstractions/IGeneralDrivelution.cs	Core updater interface contract.
src/c#/GeneralUpdate.Drivelution/Abstractions/IDriverValidator.cs	Validator interface (integrity/signature/compatibility).
src/c#/GeneralUpdate.Drivelution/Abstractions/IDriverBackup.cs	Backup/restore/delete abstraction.
src/c#/GeneralUpdate.Drivelution/Abstractions/INetworkDownloader.cs	Placeholder download interface for future extension.
src/c#/GeneralUpdate.Drivelution/Abstractions/Models/DriverInfo.cs	Driver metadata model (hash/signature/compat fields).
src/c#/GeneralUpdate.Drivelution/Abstractions/Models/UpdateStrategy.cs	Update strategy model (retry/restart/skip flags etc.).
src/c#/GeneralUpdate.Drivelution/Abstractions/Models/UpdateResult.cs	Update result model + status enum.
src/c#/GeneralUpdate.Drivelution/Abstractions/Models/ErrorInfo.cs	Error model + error type enum.
src/c#/GeneralUpdate.Drivelution/Abstractions/Exceptions/DriverUpdateExceptions.cs	Exception hierarchy for driver update operations.
src/c#/GeneralUpdate.Drivelution/Abstractions/Configuration/DriverUpdateOptions.cs	Library configuration options model.
src/c#/GeneralUpdate.Drivelution/Windows/Implementation/WindowsGeneralDrivelution.cs	Windows updater implementation (permission/validate/backup/install/verify/rollback/discovery).
src/c#/GeneralUpdate.Drivelution/Windows/Implementation/WindowsDriverValidator.cs	Windows validator (hash/signature/compat).
src/c#/GeneralUpdate.Drivelution/Windows/Implementation/WindowsDriverBackup.cs	Windows file backup/restore/delete implementation.
src/c#/GeneralUpdate.Drivelution/Windows/Helpers/WindowsSignatureHelper.cs	Windows Authenticode signature validation helper.
src/c#/GeneralUpdate.Drivelution/Windows/Helpers/WindowsPermissionHelper.cs	Windows admin check + UAC elevation helpers.
src/c#/GeneralUpdate.Drivelution/Linux/Implementation/LinuxGeneralDrivelution.cs	Linux updater implementation (sudo check, validate/backup/install/rollback/discovery).
src/c#/GeneralUpdate.Drivelution/Linux/Implementation/LinuxDriverValidator.cs	Linux validator (hash/signature via GPG/compat).
src/c#/GeneralUpdate.Drivelution/Linux/Implementation/LinuxDriverBackup.cs	Linux file backup/restore/delete implementation.
src/c#/GeneralUpdate.Drivelution/Linux/Helpers/LinuxSignatureHelper.cs	GPG signature validation helper.
src/c#/GeneralUpdate.Drivelution/Linux/Helpers/LinuxPermissionHelper.cs	Root/sudo detection + sudo execution helper.
src/c#/GeneralUpdate.Drivelution/MacOS/Implementation/MacOsGeneralDrivelution.cs	macOS placeholder implementations throwing `PlatformNotSupportedException`.
src/c#/DrivelutionTest/DrivelutionTest.csproj	New xUnit test project referencing the new library.
src/c#/DrivelutionTest/Core/DriverUpdaterFactoryTests.cs	Tests for platform factory behavior.
src/c#/DrivelutionTest/GeneralDrivelutionTests.cs	Tests for the public static entrypoint API.
src/c#/DrivelutionTest/Models/ModelTests.cs	Tests for models/enums defaulting and setters.
src/c#/DrivelutionTest/Utilities/CompatibilityCheckerTests.cs	Tests for compatibility checker utility behavior.
src/c#/DrivelutionTest/Utilities/HashValidatorTests.cs	Tests for hashing utility behavior and cancellation.
src/c#/DrivelutionTest/Utilities/VersionComparerAndRestartHelperTests.cs	Tests for SemVer comparer and restart helper basic behavior.
doc/GeneralUpdate.Drivelution.md	New long-form library documentation and examples.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-09T10:19:22Z

src/c#/GeneralUpdate.Drivelution/Linux/Helpers/LinuxSignatureHelper.cs

+            // Import trusted keys if provided
+            if (trustedKeys.Any())
+            {
+                foreach (var key in trustedKeys)
+                {
+                    await ImportGpgKeyAsync(key);
+                }
+            }


Importing trustedKeys via gpg --import/--recv-keys modifies the user's/system keyring as a side effect of validation. For library code this is risky operationally/security-wise; consider verifying against a temporary keyring (GNUPGHOME to a temp dir) or requiring callers to manage key import separately.

Copilot · 2026-02-09T10:19:22Z

src/c#/GeneralUpdate.Drivelution/Linux/Implementation/LinuxGeneralDrivelution.cs

+            // Permission check
+            await LinuxPermissionHelper.EnsureSudoAsync();
+
+            // Validation


EnsureSudoAsync() only checks sudo availability, but the subsequent install/rollback commands (insmod, modprobe, dpkg, rpm, shutdown, etc.) are executed without sudo. On a typical Linux system this means updates will fail unless the entire process is already running as root. Either require root explicitly (EnsureRoot) or route privileged operations through ExecuteWithSudoAsync/sudo execution.

Copilot · 2026-02-09T10:19:22Z

src/c#/GeneralUpdate.Drivelution/Abstractions/Models/UpdateStrategy.cs

+    /// 是否跳过签名验证（仅调试模式）
+    /// Skip signature validation (debug mode only)
+    /// </summary>
+    public bool SkipSignatureValidation { get; set; } = false;
+
+    /// <summary>
+    /// 是否跳过哈希验证（仅调试模式）
+    /// Skip hash validation (debug mode only)
+    /// </summary>
+    public bool SkipHashValidation { get; set; } = false;
+
+    /// <summary>


SkipSignatureValidation and SkipHashValidation are defined in UpdateStrategy, but the current platform implementations don’t consult them (validation is based only on whether DriverInfo.Hash/TrustedPublishers are set). This makes the API misleading; either wire these flags into ValidateAsync/UpdateAsync or remove/relocate them until supported.

Suggested change

/// 是否跳过签名验证（仅调试模式）

/// Skip signature validation (debug mode only)

/// </summary>

public bool SkipSignatureValidation { get; set; } = false;

/// <summary>

/// 是否跳过哈希验证（仅调试模式）

/// Skip hash validation (debug mode only)

/// </summary>

public bool SkipHashValidation { get; set; } = false;

/// <summary>

Copilot · 2026-02-09T10:19:23Z

doc/GeneralUpdate.Drivelution.md

+```csharp
+if (!result.Success && result.Error != null)
+{
+    Console.WriteLine($"Error Type: {result.Error.Type}");
+    Console.WriteLine($"Message: {result.Error.Message}");
+    Console.WriteLine($"Details: {result.Error.Details}");
+    Console.WriteLine($"Can Retry: {result.Error.CanRetry}");
+    Console.WriteLine($"Error Code: {result.Error.ErrorCode}");
+    Console.WriteLine($"Timestamp: {result.Error.Timestamp}");
+}
+```
+
+### Error Types
+
+```csharp
+public enum ErrorType
+{
+    PermissionDenied,          // Insufficient privileges
+    HashValidationFailed,       // Hash mismatch
+    SignatureValidationFailed,  // Invalid signature
+    CompatibilityCheckFailed,   // Incompatible driver
+    InstallationFailed,         // Installation error
+    BackupFailed,              // Backup creation failed
+    RollbackFailed,            // Rollback failed
+    NetworkError,              // Download/network issue
+    TimeoutError,              // Operation timed out
+    UnknownError               // Unexpected error
+}


The documentation references result.Error.ErrorCode and defines an ErrorType enum with values (CompatibilityCheckFailed, TimeoutError, UnknownError, etc.) that don’t match the actual code (ErrorInfo.Code and ErrorType.CompatibilityValidationFailed, Timeout, Unknown, ...). Please update the doc snippets/enums to match the implemented API so consumers don’t copy/paste broken code.

Copilot · 2026-02-09T10:19:23Z

src/c#/GeneralUpdate.Drivelution/Linux/Helpers/LinuxPermissionHelper.cs

+    public static async Task<bool> CanUseSudoAsync()
+    {
+        try
+        {
+            var startInfo = new ProcessStartInfo
+            {
+                FileName = "sudo",
+                Arguments = "-n true",
+                UseShellExecute = false,
+                RedirectStandardOutput = true,
+                RedirectStandardError = true,
+                CreateNoWindow = true
+            };
+
+            using var process = Process.Start(startInfo);
+            if (process != null)
+            {
+                await process.WaitForExitAsync();
+                return process.ExitCode == 0;


CanUseSudoAsync uses sudo -n true, which only succeeds for passwordless sudo. Users who can sudo with a password will be treated as not having sudo privileges, causing false permission failures. If interactive prompting is acceptable, drop -n; if not, adjust the error message to explicitly require passwordless sudo or running as root.

Copilot · 2026-02-09T10:19:25Z

src/c#/GeneralUpdate.Drivelution/Windows/Implementation/WindowsGeneralDrivelution.cs

+        catch (DriverValidationException ex)
+        {
+            _logger.Error(ex, "Validation failed during driver update");
+            result.Success = false;
+            result.Status = UpdateStatus.Failed;
+            result.Error = CreateErrorInfo(ex, ErrorType.HashValidationFailed, false);
+            result.StepLogs.Add($"[{DateTime.Now:HH:mm:ss}] ERROR: {ex.Message}");


DriverValidationException is always being mapped to ErrorType.HashValidationFailed, even though validation failures can also be signature/compatibility/file-not-found. This will misreport the error type to callers; set ErrorType based on ex.ValidationType (or extend the exception to carry a more specific ErrorType).

Copilot · 2026-02-09T10:19:25Z

src/c#/GeneralUpdate.Drivelution/Windows/Implementation/WindowsGeneralDrivelution.cs

+                var backupPath = GenerateBackupPath(driverInfo, strategy.BackupPath);
+                if (await BackupAsync(driverInfo, backupPath, cancellationToken))
+                {
+                    result.BackupPath = backupPath;
+                    _logger.Information("Backup created at: {BackupPath}", backupPath);
+                }


BackupAsync returns only a boolean and WindowsDriverBackup appends a timestamp to the actual backup filename, but UpdateResult.BackupPath is set to the pre-timestamp path. This makes the reported backup path incorrect and breaks later rollback logic; return/store the real backup file path from the backup layer.

Copilot · 2026-02-09T10:19:25Z

src/c#/GeneralUpdate.Drivelution/Linux/Implementation/LinuxGeneralDrivelution.cs

+            if (strategy.RequireBackup)
+            {
+                result.Status = UpdateStatus.BackingUp;
+                var backupPath = GenerateBackupPath(driverInfo, strategy.BackupPath);
+                if (await BackupAsync(driverInfo, backupPath, cancellationToken))
+                {
+                    result.BackupPath = backupPath;
+                }


Like the Windows implementation, BackupAsync sets result.BackupPath to the pre-timestamp path, but LinuxDriverBackup writes a timestamped file and rollback expects backupPath to be a directory. This makes rollback impossible; store the actual backup file path (or change backup to create a directory-based backup compatible with rollback).

Copilot · 2026-02-09T10:19:26Z

src/c#/GeneralUpdate.Drivelution/Linux/Implementation/LinuxGeneralDrivelution.cs

+            _logger.Information("Rolling back driver from backup: {BackupPath}", backupPath);
+
+            if (!Directory.Exists(backupPath))
+            {
+                _logger.Error("Backup directory not found: {BackupPath}", backupPath);
+                return false;
+            }
+
+            // Find backed up kernel modules (.ko files)
+            var koFiles = Directory.GetFiles(backupPath, "*.ko", SearchOption.AllDirectories);
+
+            if (!koFiles.Any())
+            {
+                _logger.Warning("No kernel module backups found in: {BackupPath}", backupPath);
+                return false;
+            }


RollbackAsync requires backupPath to be an existing directory and searches for *.ko, but backups are created as individual timestamped files (see LinuxDriverBackup). As a result, rollback will always fail the Directory.Exists(backupPath) check; adjust rollback to restore from the backup file or change backup format to a directory containing restored artifacts.

Copilot · 2026-02-09T10:19:26Z

src/c#/GeneralUpdate.Drivelution/Linux/Implementation/LinuxGeneralDrivelution.cs

+            // Try to get package info using dpkg-deb command
+            // Use proper argument passing to avoid injection issues
+            var escapedPath = debPath.Replace("'", "'\\''");
+            var output = await ExecuteCommandAsync("dpkg-deb", $"-I '{escapedPath}'", cancellationToken);
+            var lines = output.Split('\n');


ParseDebPackageAsync/ParseRpmPackageAsync wrap the path in single quotes inside the argument string (e.g., -I '{escapedPath}'). Since UseShellExecute=false, these quotes are passed literally to dpkg-deb/rpm, so the commands may fail to locate the file. Use ArgumentList (preferred) or quote the path in a way appropriate for direct argv passing (typically no extra quoting needed if using ArgumentList).

add GeneralUpdate.Drivelution

2485009

JusterZhu assigned Copilot Feb 8, 2026

JusterZhu added the features New feature or request label Feb 8, 2026

JusterZhu linked an issue Feb 8, 2026 that may be closed by this pull request

[FEATURE] Driver Upgrade Function #101

Closed

Copilot AI mentioned this pull request Feb 8, 2026

Add comprehensive documentation for GeneralUpdate.Drivelution #139

Merged

Copilot AI mentioned this pull request Feb 8, 2026

Add comprehensive test suite for GeneralUpdate.Drivelution #140

Merged

Copilot AI mentioned this pull request Feb 8, 2026

Rename DriverUpdate to Drivelution across codebase #141

Merged

Copilot AI mentioned this pull request Feb 9, 2026

Add GetDriversFromDirectoryAsync for local driver discovery #142

Merged

17 tasks

JusterZhu marked this pull request as ready for review February 9, 2026 09:57

Copilot AI review requested due to automatic review settings February 9, 2026 09:57

JusterZhu merged commit 2b21a77 into master Feb 9, 2026
4 checks passed

JusterZhu deleted the driver branch February 9, 2026 09:58

Copilot started reviewing on behalf of JusterZhu February 9, 2026 10:02 View session

Copilot AI reviewed Feb 9, 2026

View reviewed changes

Conversation

JusterZhu commented Feb 8, 2026

Uh oh!

JusterZhu commented Feb 8, 2026

Uh oh!

Copilot AI commented Feb 8, 2026

Uh oh!

JusterZhu commented Feb 8, 2026

Uh oh!

Copilot AI commented Feb 8, 2026

Uh oh!

JusterZhu commented Feb 8, 2026

Uh oh!

Copilot AI commented Feb 8, 2026

Uh oh!

JusterZhu commented Feb 9, 2026

Uh oh!

JusterZhu commented Feb 9, 2026

Uh oh!

Copilot AI commented Feb 9, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants