Material theme: fix issues after designer review and WG check #32520
+283
−264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts Material (and a couple of Fluent) theme color tokens to align with post–designer review/WG checks, mainly by making several colors mode-dependent (light vs dark) and normalizing a few token defaults.
Changes:
- Material: update base hover/focus background alphas and make button/grid/filterBuilder color tokens explicitly mode-driven.
- Material/Fluent gridBase: simplify
$header-filter-color-emptydefaulting logic and adjust modified/invalid coloring tokens. - Fluent/Material filterBuilder: revise value button colors and set focused text color per mode.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme-scss/scss/widgets/material/gridBase/_colors.scss | Makes modified/invalid colors mode-specific and normalizes $header-filter-color-empty defaulting. |
| packages/devextreme-scss/scss/widgets/material/filterBuilder/_colors.scss | Updates value button colors and sets focused text color based on light/dark mode. |
| packages/devextreme-scss/scss/widgets/material/button/_colors.scss | Makes normal contained button background mode-specific (light vs dark). |
| packages/devextreme-scss/scss/widgets/material/_colors.scss | Tweaks base hover/focus background alpha values for light/dark modes. |
| packages/devextreme-scss/scss/widgets/fluent/gridBase/_colors.scss | Sets a non-null default for column chooser item color and normalizes $header-filter-color-empty. |
| packages/devextreme-scss/scss/widgets/fluent/filterBuilder/_colors.scss | Updates value button colors and sets focused text color based on light/dark mode. |
EugeniyKiyashko
force-pushed
the
26_1_fix_remaining_color_contrast-issues
branch
from
d477876 to
dc8fe7a
Compare
EugeniyKiyashko
force-pushed
the
26_1_fix_remaining_color_contrast-issues
branch
from
8bf0de1 to
cbb22f4
Compare
Shuvaevmedia
approved these changes
Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.