Skip to content

Conversation

@mpreyskurantov
Copy link
Contributor

Co-authored-by: Mikhail Preyskurantov <5574159+mpreyskurantov@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes how Excel exporter-related types are surfaced in generated typings by moving CellAddress/CellRange to a shared internal definition and re-exporting them through the intended public entrypoints, while also adjusting documentation visibility for several helper types.

Changes:

  • Reworked CellAddress / CellRange to be defined once and re-exported (instead of duplicated interface declarations).
  • Added DevExpress.exportInternal type container (and mapped public DevExpress.excelExporter types to it).
  • Marked several helper/public-facing-but-doc-unwanted types as @hidden in .d.ts files; updated wrapper exports to include the Excel cell range/address types.

Reviewed changes

Copilot reviewed 3 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/devextreme/ts/dx.all.d.ts Replaced CellAddress/CellRange interfaces with aliases and introduced DevExpress.exportInternal module in the bundled typings.
packages/devextreme/js/exporter/export_load_panel.d.ts Marked ExportLoadPanel as hidden for doc generation.
packages/devextreme/js/excel_exporter.types.d.ts Removed local CellAddress/CellRange definitions and re-exported them from a shared types file.
packages/devextreme/js/excel_exporter.d.ts Adjusted exports so CellAddress/CellRange come from common/export/excel.
packages/devextreme/js/events/events.types.d.ts Hid DxEvent in docs.
packages/devextreme/js/data/data_source.d.ts Hid DataSourceLike in docs.
packages/devextreme/js/core/utils/deferred.d.ts Hid DxPromise in docs.
packages/devextreme/js/core/templates/template.d.ts Hid dxTemplateOptions in docs.
packages/devextreme/js/core/element.d.ts Hid DxElement / UserDefinedElement in docs.
packages/devextreme/js/common/export/excel.types.d.ts Added new shared internal type declarations for Excel export (CellAddress, CellRange).
packages/devextreme/js/common/export/excel.d.ts Re-exported CellAddress/CellRange publicly via type aliases and used them in exported APIs.
packages/devextreme-vue/src/common/export/excel.ts Re-exported CellAddress/CellRange from devextreme Excel export entry.
packages/devextreme-react/src/common/export/excel.ts Re-exported CellAddress/CellRange from devextreme Excel export entry.
packages/devextreme-angular/src/common/export/excel/index.ts Re-exported CellAddress/CellRange from devextreme Excel export entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants