Add workflow to enforce Datadog merge queue#10590
Open
PerfectSlayer wants to merge 1 commit intomasterfrom
Open
Add workflow to enforce Datadog merge queue#10590PerfectSlayer wants to merge 1 commit intomasterfrom
PerfectSlayer wants to merge 1 commit intomasterfrom
Conversation
Contributor
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 12 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~fb53508ca1, baseline=1.60.0-SNAPSHOT~f215026f2d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.068 s) : 0, 1067670
Total [baseline] (10.972 s) : 0, 10971755
Agent [candidate] (1.066 s) : 0, 1066434
Total [candidate] (10.903 s) : 0, 10902510
section appsec
Agent [baseline] (1.244 s) : 0, 1244013
Total [baseline] (11.001 s) : 0, 11001159
Agent [candidate] (1.242 s) : 0, 1241769
Total [candidate] (11.032 s) : 0, 11032060
section iast
Agent [baseline] (1.25 s) : 0, 1249529
Total [baseline] (11.21 s) : 0, 11209669
Agent [candidate] (1.236 s) : 0, 1236299
Total [candidate] (11.187 s) : 0, 11187311
section profiling
Agent [baseline] (1.192 s) : 0, 1191983
Total [baseline] (11.021 s) : 0, 11020900
Agent [candidate] (1.19 s) : 0, 1189502
Total [candidate] (10.935 s) : 0, 10935476
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~fb53508ca1, baseline=1.60.0-SNAPSHOT~f215026f2d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.204 ms) : 0, 1204
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (629.287 ms) : 0, 629287
BytebuddyAgent [candidate] (629.519 ms) : 0, 629519
AgentMeter [baseline] (29.012 ms) : 0, 29012
AgentMeter [candidate] (29.097 ms) : 0, 29097
GlobalTracer [baseline] (258.348 ms) : 0, 258348
GlobalTracer [candidate] (257.758 ms) : 0, 257758
AppSec [baseline] (32.737 ms) : 0, 32737
AppSec [candidate] (32.972 ms) : 0, 32972
Debugger [baseline] (65.108 ms) : 0, 65108
Debugger [candidate] (63.739 ms) : 0, 63739
Remote Config [baseline] (617.874 µs) : 0, 618
Remote Config [candidate] (621.297 µs) : 0, 621
Telemetry [baseline] (9.863 ms) : 0, 9863
Telemetry [candidate] (11.529 ms) : 0, 11529
Flare Poller [baseline] (6.046 ms) : 0, 6046
Flare Poller [candidate] (4.606 ms) : 0, 4606
section appsec
crashtracking [baseline] (1.214 ms) : 0, 1214
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (662.17 ms) : 0, 662170
BytebuddyAgent [candidate] (660.255 ms) : 0, 660255
AgentMeter [baseline] (12.047 ms) : 0, 12047
AgentMeter [candidate] (12.04 ms) : 0, 12040
GlobalTracer [baseline] (258.175 ms) : 0, 258175
GlobalTracer [candidate] (258.303 ms) : 0, 258303
AppSec [baseline] (167.561 ms) : 0, 167561
AppSec [candidate] (167.996 ms) : 0, 167996
Debugger [baseline] (67.467 ms) : 0, 67467
Debugger [candidate] (67.321 ms) : 0, 67321
Remote Config [baseline] (666.002 µs) : 0, 666
Remote Config [candidate] (660.159 µs) : 0, 660
Telemetry [baseline] (9.723 ms) : 0, 9723
Telemetry [candidate] (9.652 ms) : 0, 9652
Flare Poller [baseline] (4.358 ms) : 0, 4358
Flare Poller [candidate] (3.738 ms) : 0, 3738
IAST [baseline] (25.074 ms) : 0, 25074
IAST [candidate] (25.229 ms) : 0, 25229
section iast
crashtracking [baseline] (1.204 ms) : 0, 1204
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (808.883 ms) : 0, 808883
BytebuddyAgent [candidate] (798.581 ms) : 0, 798581
AgentMeter [baseline] (11.757 ms) : 0, 11757
AgentMeter [candidate] (11.291 ms) : 0, 11291
GlobalTracer [baseline] (250.79 ms) : 0, 250790
GlobalTracer [candidate] (249.223 ms) : 0, 249223
AppSec [baseline] (32.61 ms) : 0, 32610
AppSec [candidate] (32.294 ms) : 0, 32294
Debugger [baseline] (68.65 ms) : 0, 68650
Debugger [candidate] (68.662 ms) : 0, 68662
Remote Config [baseline] (557.195 µs) : 0, 557
Remote Config [candidate] (540.554 µs) : 0, 541
Telemetry [baseline] (8.622 ms) : 0, 8622
Telemetry [candidate] (8.607 ms) : 0, 8607
Flare Poller [baseline] (3.427 ms) : 0, 3427
Flare Poller [candidate] (3.451 ms) : 0, 3451
IAST [baseline] (27.274 ms) : 0, 27274
IAST [candidate] (27.023 ms) : 0, 27023
section profiling
ProfilingAgent [baseline] (99.201 ms) : 0, 99201
ProfilingAgent [candidate] (98.74 ms) : 0, 98740
crashtracking [baseline] (1.235 ms) : 0, 1235
crashtracking [candidate] (1.228 ms) : 0, 1228
BytebuddyAgent [baseline] (683.144 ms) : 0, 683144
BytebuddyAgent [candidate] (681.74 ms) : 0, 681740
AgentMeter [baseline] (8.615 ms) : 0, 8615
AgentMeter [candidate] (8.609 ms) : 0, 8609
GlobalTracer [baseline] (216.201 ms) : 0, 216201
GlobalTracer [candidate] (215.656 ms) : 0, 215656
AppSec [baseline] (32.567 ms) : 0, 32567
AppSec [candidate] (32.646 ms) : 0, 32646
Debugger [baseline] (67.491 ms) : 0, 67491
Debugger [candidate] (67.405 ms) : 0, 67405
Remote Config [baseline] (631.096 µs) : 0, 631
Remote Config [candidate] (638.829 µs) : 0, 639
Telemetry [baseline] (9.044 ms) : 0, 9044
Telemetry [candidate] (9.046 ms) : 0, 9046
Flare Poller [baseline] (3.797 ms) : 0, 3797
Flare Poller [candidate] (3.806 ms) : 0, 3806
Profiling [baseline] (99.772 ms) : 0, 99772
Profiling [candidate] (99.326 ms) : 0, 99326
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~fb53508ca1, baseline=1.60.0-SNAPSHOT~f215026f2d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1065953
Total [baseline] (8.756 s) : 0, 8755636
Agent [candidate] (1.076 s) : 0, 1076199
Total [candidate] (8.75 s) : 0, 8749692
section iast
Agent [baseline] (1.252 s) : 0, 1251677
Total [baseline] (9.411 s) : 0, 9411166
Agent [candidate] (1.244 s) : 0, 1243905
Total [candidate] (9.394 s) : 0, 9394339
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~fb53508ca1, baseline=1.60.0-SNAPSHOT~f215026f2d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.206 ms) : 0, 1206
BytebuddyAgent [baseline] (628.994 ms) : 0, 628994
BytebuddyAgent [candidate] (635.748 ms) : 0, 635748
AgentMeter [baseline] (28.947 ms) : 0, 28947
AgentMeter [candidate] (29.332 ms) : 0, 29332
GlobalTracer [baseline] (257.515 ms) : 0, 257515
GlobalTracer [candidate] (260.089 ms) : 0, 260089
AppSec [baseline] (32.944 ms) : 0, 32944
AppSec [candidate] (33.095 ms) : 0, 33095
Debugger [baseline] (60.766 ms) : 0, 60766
Debugger [candidate] (61.997 ms) : 0, 61997
Remote Config [baseline] (641.434 µs) : 0, 641
Remote Config [candidate] (638.668 µs) : 0, 639
Telemetry [baseline] (14.019 ms) : 0, 14019
Telemetry [candidate] (12.223 ms) : 0, 12223
Flare Poller [baseline] (5.409 ms) : 0, 5409
Flare Poller [candidate] (6.179 ms) : 0, 6179
section iast
crashtracking [baseline] (1.22 ms) : 0, 1220
crashtracking [candidate] (1.199 ms) : 0, 1199
BytebuddyAgent [baseline] (810.179 ms) : 0, 810179
BytebuddyAgent [candidate] (805.46 ms) : 0, 805460
AgentMeter [baseline] (11.766 ms) : 0, 11766
AgentMeter [candidate] (11.526 ms) : 0, 11526
GlobalTracer [baseline] (251.352 ms) : 0, 251352
GlobalTracer [candidate] (249.928 ms) : 0, 249928
AppSec [baseline] (35.511 ms) : 0, 35511
AppSec [candidate] (34.782 ms) : 0, 34782
Debugger [baseline] (65.736 ms) : 0, 65736
Debugger [candidate] (65.549 ms) : 0, 65549
Remote Config [baseline] (543.284 µs) : 0, 543
Remote Config [candidate] (540.893 µs) : 0, 541
Telemetry [baseline] (8.729 ms) : 0, 8729
Telemetry [candidate] (8.581 ms) : 0, 8581
Flare Poller [baseline] (3.532 ms) : 0, 3532
Flare Poller [candidate] (3.506 ms) : 0, 3506
IAST [baseline] (27.369 ms) : 0, 27369
IAST [candidate] (27.146 ms) : 0, 27146
LoadParameters
See matching parameters
SummaryFound 6 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~fb53508ca1, baseline=1.60.0-SNAPSHOT~f215026f2d
dateFormat X
axisFormat %s
section baseline
no_agent (1.189 ms) : 1177, 1201
. : milestone, 1189,
iast (3.233 ms) : 3190, 3276
. : milestone, 3233,
iast_FULL (6.052 ms) : 5990, 6114
. : milestone, 6052,
iast_GLOBAL (3.373 ms) : 3331, 3416
. : milestone, 3373,
profiling (2.09 ms) : 2071, 2110
. : milestone, 2090,
tracing (1.776 ms) : 1761, 1791
. : milestone, 1776,
section candidate
no_agent (1.183 ms) : 1171, 1194
. : milestone, 1183,
iast (3.258 ms) : 3215, 3301
. : milestone, 3258,
iast_FULL (5.824 ms) : 5765, 5883
. : milestone, 5824,
iast_GLOBAL (3.465 ms) : 3415, 3515
. : milestone, 3465,
profiling (1.925 ms) : 1910, 1941
. : milestone, 1925,
tracing (1.757 ms) : 1743, 1771
. : milestone, 1757,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~fb53508ca1, baseline=1.60.0-SNAPSHOT~f215026f2d
dateFormat X
axisFormat %s
section baseline
no_agent (19.453 ms) : 19254, 19652
. : milestone, 19453,
appsec (18.59 ms) : 18400, 18779
. : milestone, 18590,
code_origins (18.521 ms) : 18334, 18709
. : milestone, 18521,
iast (19.253 ms) : 19059, 19447
. : milestone, 19253,
profiling (18.852 ms) : 18661, 19043
. : milestone, 18852,
tracing (18.625 ms) : 18435, 18814
. : milestone, 18625,
section candidate
no_agent (17.704 ms) : 17524, 17885
. : milestone, 17704,
appsec (18.769 ms) : 18579, 18959
. : milestone, 18769,
code_origins (17.766 ms) : 17588, 17944
. : milestone, 17766,
iast (17.605 ms) : 17430, 17780
. : milestone, 17605,
profiling (18.575 ms) : 18390, 18760
. : milestone, 18575,
tracing (17.766 ms) : 17590, 17942
. : milestone, 17766,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~fb53508ca1, baseline=1.60.0-SNAPSHOT~f215026f2d
dateFormat X
axisFormat %s
section baseline
no_agent (15.059 s) : 15059000, 15059000
. : milestone, 15059000,
appsec (14.607 s) : 14607000, 14607000
. : milestone, 14607000,
iast (18.037 s) : 18037000, 18037000
. : milestone, 18037000,
iast_GLOBAL (18.033 s) : 18033000, 18033000
. : milestone, 18033000,
profiling (15.056 s) : 15056000, 15056000
. : milestone, 15056000,
tracing (14.839 s) : 14839000, 14839000
. : milestone, 14839000,
section candidate
no_agent (15.313 s) : 15313000, 15313000
. : milestone, 15313000,
appsec (14.754 s) : 14754000, 14754000
. : milestone, 14754000,
iast (18.066 s) : 18066000, 18066000
. : milestone, 18066000,
iast_GLOBAL (17.743 s) : 17743000, 17743000
. : milestone, 17743000,
profiling (15.562 s) : 15562000, 15562000
. : milestone, 15562000,
tracing (14.829 s) : 14829000, 14829000
. : milestone, 14829000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~fb53508ca1, baseline=1.60.0-SNAPSHOT~f215026f2d
dateFormat X
axisFormat %s
section baseline
no_agent (1.483 ms) : 1472, 1495
. : milestone, 1483,
appsec (3.808 ms) : 3585, 4031
. : milestone, 3808,
iast (2.282 ms) : 2212, 2353
. : milestone, 2282,
iast_GLOBAL (2.322 ms) : 2251, 2392
. : milestone, 2322,
profiling (2.121 ms) : 2063, 2179
. : milestone, 2121,
tracing (2.09 ms) : 2035, 2145
. : milestone, 2090,
section candidate
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (3.838 ms) : 3614, 4062
. : milestone, 3838,
iast (2.278 ms) : 2208, 2348
. : milestone, 2278,
iast_GLOBAL (2.32 ms) : 2249, 2390
. : milestone, 2320,
profiling (2.135 ms) : 2077, 2193
. : milestone, 2135,
tracing (2.079 ms) : 2025, 2134
. : milestone, 2079,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR adds a workflow that will prevent GitHub merge queue to pass, and comment to trigger the Datadog merge queue instead.
Motivation
We would like to enable GitHub merge queue to prevent pull requests to be merge without merge queue.
But any protection rule will make the PR non eligible to the Datadog merge queue.
Additional Notes
I don't think the bot will be able to trigger the merge (it might not have the permission) but let's try it anyway.
For now, this check is not required but it will be when we enable GitHub merge queue.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.