Skip to content

Add primitive versions of setMetric to DDSpanContext #10516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dougqh wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add primitive versions of setMetric to DDSpanContext #10516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3047d44
Adding primitive versions of setMetric
dougqh Feb 3, 2026
1748c18
Adding tests
dougqh Feb 3, 2026
2adef7a
Merge branch 'master' into dougqh/avoid-metric-boxing
dougqh Feb 5, 2026
8761fc7
Merge branch 'master' into dougqh/avoid-metric-boxing
dougqh Feb 19, 2026
eb07a05
Adding float support
dougqh Feb 19, 2026
74f79df
Adding cast to Number
dougqh Feb 19, 2026
ed8eb94
spotless
dougqh Feb 19, 2026
4019a73
Merge branch 'master' into dougqh/avoid-metric-boxing
dougqh Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...rumentation-testing/src/main/groovy/datadog/trace/agent/test/TrackingSpanDecorator.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,11 @@ class TrackingSpanDecorator implements AgentSpan {
return delegate.setMetric(key, value)
}

@Override
AgentSpan setMetric(CharSequence key, float value) {
return delegate.setMetric(key, value)
}

@Override
AgentSpan setMetric(CharSequence key, long value) {
return delegate.setMetric(key, value)
Expand Down
5 changes: 5 additions & 0 deletions ...opentelemetry-0.3/src/main/java/datadog/trace/instrumentation/opentelemetry/OtelSpan.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,11 @@ public MutableSpan setMetric(final CharSequence metric, final long value) {
return delegate.setMetric(metric, value);
}

@Override
public MutableSpan setMetric(final CharSequence metric, final float value) {
return delegate.setMetric(metric, value);
}

@Override
public MutableSpan setMetric(final CharSequence metric, final double value) {
return delegate.setMetric(metric, value);
Expand Down
6 changes: 6 additions & 0 deletions ...ng/opentracing-0.31/src/main/java/datadog/trace/instrumentation/opentracing31/OTSpan.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,12 @@ public OTSpan setMetric(final CharSequence metric, final long value) {
return this;
}

@Override
public OTSpan setMetric(final CharSequence metric, final float value) {
delegate.setMetric(metric, value);
return this;
}

@Override
public OTSpan setMetric(final CharSequence metric, final double value) {
delegate.setMetric(metric, value);
Expand Down
6 changes: 6 additions & 0 deletions ...ng/opentracing-0.32/src/main/java/datadog/trace/instrumentation/opentracing32/OTSpan.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,12 @@ public OTSpan setMetric(final CharSequence metric, final long value) {
return this;
}

@Override
public OTSpan setMetric(final CharSequence metric, final float value) {
delegate.setMetric(metric, value);
return this;
}

@Override
public OTSpan setMetric(final CharSequence metric, final double value) {
delegate.setMetric(metric, value);
Expand Down
2 changes: 2 additions & 0 deletions dd-trace-api/src/main/java/datadog/trace/api/interceptor/MutableSpan.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ default Object getTag(String key) {

MutableSpan setMetric(final CharSequence metric, final long value);

MutableSpan setMetric(final CharSequence metric, final float value);

MutableSpan setMetric(final CharSequence metric, final double value);

boolean isError();
Expand Down
24 changes: 24 additions & 0 deletions dd-trace-core/src/main/java/datadog/trace/core/DDSpanContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -751,6 +751,30 @@ public void setMetric(final CharSequence key, final Number value) {
}
}

public void setMetric(final CharSequence key, final int value) {
synchronized (unsafeTags) {
unsafeTags.set(key.toString(), value);
}
}

public void setMetric(final CharSequence key, final long value) {
synchronized (unsafeTags) {
unsafeTags.set(key.toString(), value);
}
}

public void setMetric(final CharSequence key, final float value) {
synchronized (unsafeTags) {
unsafeTags.set(key.toString(), value);
}
}

public void setMetric(final CharSequence key, final double value) {
synchronized (unsafeTags) {
unsafeTags.set(key.toString(), value);
}
}

public void setMetric(final TagMap.EntryReader entry) {
if (entry == null) {
return;
Expand Down
2 changes: 1 addition & 1 deletion dd-trace-core/src/test/groovy/datadog/trace/core/DDSpanContextTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ class DDSpanContextTest extends DDCoreSpecification {
def context = span.context()

when:
context.setMetric("test", value)
context.setMetric("test", (Number)value)

then:
type.isInstance(context.getTag("test"))
Expand Down
53 changes: 53 additions & 0 deletions dd-trace-core/src/test/java/datadog/trace/core/SpanTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package datadog.trace.core;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertInstanceOf;

import datadog.trace.api.TagMap;
import datadog.trace.bootstrap.instrumentation.api.AgentSpan;
Expand All @@ -10,6 +11,58 @@
public class SpanTest {
static final CoreTracer TRACER = CoreTracer.builder().build();

@Test
@DisplayName("setMetric: int")
public void setMetricInt() {
int expected = 2;

AgentSpan span = TRACER.startSpan("foo", "foo");
span.setMetric("int", expected);

Object value = span.getTag("int");
assertInstanceOf(Integer.class, value);
assertEquals(Integer.valueOf(expected), value);
}

@Test
@DisplayName("setMetric: long")
public void setMetricLong() {
long expected = 20L;

AgentSpan span = TRACER.startSpan("foo", "foo");
span.setMetric("long", expected);

Object value = span.getTag("long");
assertInstanceOf(Long.class, value);
assertEquals(Long.valueOf(expected), value);
}

@Test
@DisplayName("setMetric: float")
public void setMetricFloat() {
float expected = 2.718F;

AgentSpan span = TRACER.startSpan("foo", "foo");
span.setMetric("float", expected);

Object value = span.getTag("float");
assertInstanceOf(Float.class, value);
assertEquals(Float.valueOf(expected), value);
}

@Test
@DisplayName("setMetric: double")
public void setMetricDouble() {
double expected = 3.1415D;

AgentSpan span = TRACER.startSpan("foo", "foo");
span.setMetric("double", expected);

Object value = span.getTag("double");
assertInstanceOf(Double.class, value);
assertEquals(Double.valueOf(expected), value);
}

@Test
@DisplayName("setTag: TagMap.Entry")
public void setTagEntry() {
Expand Down
6 changes: 6 additions & 0 deletions dd-trace-ot/src/main/java/datadog/opentracing/OTSpan.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,12 @@ public OTSpan setMetric(final CharSequence metric, final long value) {
return this;
}

@Override
public OTSpan setMetric(final CharSequence metric, final float value) {
delegate.setMetric(metric, value);
return this;
}

@Override
public OTSpan setMetric(final CharSequence metric, final double value) {
delegate.setMetric(metric, value);
Expand Down
3 changes: 3 additions & 0 deletions internal-api/src/main/java/datadog/trace/bootstrap/instrumentation/api/AgentSpan.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,9 @@ default boolean isValid() {
@Override
AgentSpan setMetric(CharSequence key, long value);

@Override
AgentSpan setMetric(CharSequence key, float value);

@Override
AgentSpan setMetric(CharSequence key, double value);

Expand Down
5 changes: 5 additions & 0 deletions internal-api/src/main/java/datadog/trace/bootstrap/instrumentation/api/ImmutableSpan.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,11 @@ public AgentSpan setMetric(CharSequence key, long value) {
return this;
}

@Override
public AgentSpan setMetric(CharSequence key, float value) {
return this;
}

@Override
public AgentSpan setMetric(CharSequence key, double value) {
return this;
Expand Down
Loading