SSF 97 pantry management backend by swarkewalia · Pull Request #76 · Code-4-Community/ssf

swarkewalia · 2025-12-03T23:48:30Z

ℹ️ Issue 97

Closes 97

📝 Description

Added a new endpoint (getApprovedPantries) to return all information necessary for the pantry management frontend about pantries with 'approved' status - includes assigned volunteers.
Added a second new endpoint (updatePantryVolunteers) to overwrite the set of volunteers assigned to a pantry with a new set of volunteers.
Added a type file for pantries and included ApprovedPantryResponse and AssignedVolunteer types.
Added a controller test for each endpoint.

✔️ Verification

Tested both endpoints using curl. Made sure GET endpoint retrieved all approved pantries with assigned volunteers, and that the PUT endpoint overwrites volunteer assignments successfully.

dburkhart07 · 2025-12-06T18:27:49Z

See slack comment

dburkhart07

Make these initial changes, also see message I sent you.

dburkhart07 · 2026-01-18T06:47:23Z

.gitignore

 yarn-error.log
 testem.log
 /typings
-.nx


Why is this here? Can we get rid of it?

package.json

apps/frontend/src/types/types.ts

dburkhart07 · 2026-01-18T06:50:29Z

apps/frontend/src/types/types.ts

  pantries?: Pantry[];
 }

-export interface UserDto {


This should not be deleted either I dont think.

apps/frontend/src/theme.ts

…com/Code-4-Community/ssf into sk/SSF-97-pantry-management-backend

…k/SSF-97-pantry-management-backend

…com/Code-4-Community/ssf into sk/SSF-97-pantry-management-backend

dburkhart07

Few initial things. Also, I do not see the second half of the ticket requirement to make a new endpoint for this: Add a new endpoint to overwrite the set of volunteers assigned to a pantry with a new set of volunteers for intended use case

dburkhart07 · 2026-01-23T00:38:57Z

apps/backend/src/pantries/types.ts

+    email: string;
+    phone: string;
+  };
+  refrigeratedDonation: string;


This should use the enum

dburkhart07 · 2026-01-23T00:39:04Z

apps/backend/src/pantries/types.ts

+  };
+  refrigeratedDonation: string;
+  allergenClients: string;
+  status: string;


dburkhart07 · 2026-01-23T00:43:44Z

apps/backend/src/pantries/types.ts

@@ -1,3 +1,35 @@
+export interface ApprovedPantryResponse {


I think we are going to need more info than this for our approved pantry response. For one, all these pantries are approved so we shouldnt need the status. Additionally, check out the Figma for the frontend: https://www.figma.com/design/brc5luMhizIFp893XIutYe/SP26---SSF-Designs?node-id=756-11085&t=3UiKr0MdYxCcdUUK-0

The modal that pops up with Pantry Details should tell you what information we need.

Sorry, there may have been some confusion here. It's fine if we have to make another API call to get the full details about a pantry when the user navigates to the "pantry details" page - we just need the info for the main table (as well as the IDs necessary to be able to navigate to the other pages)

dburkhart07 · 2026-01-23T00:44:18Z

apps/backend/src/pantries/pantries.service.ts

  }

+
+  async getApprovedPantriesWithVolunteers(): Promise<ApprovedPantryResponse[]> {


See comment in the type.ts file, this will need to change too.

dburkhart07 · 2026-01-23T00:45:31Z

apps/backend/src/pantries/pantries.controller.ts

    return this.pantriesService.getPendingPantries();
  }

+  @Get('/approved')


We should write a test for this as well.

…k/SSF-97-pantry-management-backend

apps/backend/src/pantries/pantries.controller.spec.ts

…k/SSF-97-pantry-management-backend

dburkhart07 · 2026-02-13T05:58:41Z

Final comments:

We need to add volunteers to the relations that are returned in the getApprovedPantries function
We need to also make it so that, we know every volunteerId being included is an actual volunteer. To do this, we will need to find the user, and confirm the user.role == Role.VOLUNTEER
Make sure that in the orders.service.spec.ts file, we delete the mock variables, as they're not being moved
Make sure the ci tests are passing

dburkhart07

LGTM! Thanks for responding to so much back-and-forth 🔴🐼

Yurika-Kan

first round of review!
found a field that was missing

done: jest tests ran
pending: testing via postman

litttt

apps/backend/src/pantries/pantries.controller.spec.ts

Yurika-Kan · 2026-02-22T00:28:26Z

apps/backend/src/pantries/pantries.service.ts

+      contactPhone: pantry.pantryUser.phone,
+      shipmentAddressLine1: pantry.shipmentAddressLine1,
+      shipmentAddressCity: pantry.shipmentAddressCity,
+      shipmentAddressZip: pantry.shipmentAddressZip,


shipmentAddressState is also missing here!

Yurika-Kan · 2026-02-22T01:11:03Z

apps/backend/src/pantries/types.ts

+  contactEmail: string;
+  contactPhone: string;
+  shipmentAddressLine1: string;
+  shipmentAddressCity: string;


can zip be after state & country?

Yurika-Kan

hefty second review! some small changes, adding auth gating, testing, and a bit more! thanks for the great work so far <3

(update) tested:

postman calls

Yurika-Kan · 2026-02-25T07:05:53Z

apps/backend/src/pantries/pantries.controller.spec.ts

+          shipmentAddressLine1: '123 Main Street',
+          shipmentAddressCity: 'Boston',
+          shipmentAddressZip: '02101',
+          shipmentAddressState: 'MA',


can you make it so state comes before zip?

Yurika-Kan · 2026-02-25T07:09:09Z

apps/backend/src/pantries/pantries.controller.ts

@@ -16,6 +17,7 @@ import { Roles } from '../auth/roles.decorator';
 import { ValidationPipe } from '@nestjs/common';


can we add this to the list of imports above in the first lines?

Yurika-Kan · 2026-02-25T07:10:15Z

apps/backend/src/pantries/pantries.controller.ts

 import { ValidationPipe } from '@nestjs/common';
 import { PantryApplicationDto } from './dtos/pantry-application.dto';
 import { ApiBody } from '@nestjs/swagger';
+import { ApprovedPantryResponse } from './types';


also here add this import into the list of imports below so that we aren't unnecessarily calling multiple imports of the same file

Yurika-Kan · 2026-02-25T07:18:15Z

apps/backend/src/pantries/pantries.controller.ts

@@ -56,6 +58,11 @@ export class PantriesController {
    return this.pantriesService.getPendingPantries();
  }



since we began auth gating endpoints by role, let's continue that here by making this only accessible to admin role - aligned with the feature implications of this backend ticket

Yurika-Kan · 2026-02-25T07:25:37Z

apps/backend/src/pantries/pantries.controller.ts

      attachments,
    );
  }
+


same here with annotating this to be accessible only for admin

Yurika-Kan · 2026-02-25T07:33:14Z

apps/backend/src/pantries/types.ts

+  name: string;
+  email: string;
+  phone: string;
+  role: string;


we have a user enum that we should use instead of string here to determine role!

Yurika-Kan · 2026-02-25T07:37:42Z

apps/backend/src/pantries/pantries.service.spec.ts

+        },
      ],
    }).compile();



missing tests for getApprovedPantriesWithVolunteers & updatePantryVolunteers

Yurika-Kan · 2026-02-25T07:39:57Z

apps/backend/src/pantries/pantries.controller.spec.ts

 import { PantryApplicationDto } from './dtos/pantry-application.dto';
 import { OrdersService } from '../orders/order.service';
 import { Order } from '../orders/order.entity';
+import { ApprovedPantryResponse } from './types';


lets add this to the list of imports below!

Yurika-Kan · 2026-02-25T07:41:03Z

apps/backend/src/pantries/types.ts

+  contactEmail: string;
+  contactPhone: string;
+  shipmentAddressLine1: string;
+  shipmentAddressCity: string;


can zip be after state & country?

Yurika-Kan · 2026-02-25T07:53:37Z

apps/backend/src/pantries/types.ts

+  name: string;
+  email: string;
+  phone: string;
+  role: string;


i don't think we need to save role of the volunteer here - they should always be volunteer - could you delete this everywhere in this implementation? @sam-schu lmk thoughts

I'm fine either way - this type seems to only be used as part of the return of the endpoint to get info about the approved pantries, where I agree it's not strictly necessary that we return the role of every assigned volunteer but it also doesn't hurt anything

sam-schu

Overall, for the endpoint to get info about approved pantries I would recommend either:

return full pantry/volunteer details as you pretty much are now, but simplify by returning them as returned by typeorm, rather than mapping all the individual fields
- can define return types in terms of Pantry and User rather than making new interfaces
- just make sure to remove the users' cognito subs from the data being returned
or limit returned info to what is necessary for the frontend, which will make the map and interfaces much more concise

sam-schu · 2026-02-25T18:12:56Z

apps/backend/src/pantries/pantries.service.ts

+      relations: ['volunteers', 'pantryUser'],
+    });
+
+    return pantries.map((pantry) => ({


Can you take a look at what the return from the above call to TypeORM looks like? That should likely have all the information we need, it doesn't look like this map is doing much other than copying all the fields from one object to another. If we do go with the current approach rather than just returning pantries (with volunteers' cognito subs removed), we should make things more concise by limiting to the fields that are actually needed by the admin pantry management page this endpoint is for

sam-schu · 2026-02-25T18:14:07Z

apps/backend/src/pantries/pantries.service.ts

+      newsletterSubscription: pantry.newsletterSubscription ?? false,
+      volunteers: (pantry.volunteers || []).map((volunteer) => ({
+        userId: volunteer.id,
+        name: `${volunteer.firstName} ${volunteer.lastName}`,


We should not be combining the first and last names into one field here, this will make things more difficult for the frontend which needs to show the user's initials

sam-schu · 2026-02-25T18:15:29Z

apps/backend/src/pantries/types.ts

@@ -1,3 +1,40 @@
+export interface ApprovedPantryResponse {


Both of these interfaces look very similar to the Pantry and User entity types. Can we define the return types using those rather than re-listing out all their fields?

sam-schu · 2026-02-25T18:18:55Z

apps/backend/src/pantries/types.ts

@@ -1,3 +1,35 @@
+export interface ApprovedPantryResponse {


Sorry, there may have been some confusion here. It's fine if we have to make another API call to get the full details about a pantry when the user navigates to the "pantry details" page - we just need the info for the main table (as well as the IDs necessary to be able to navigate to the other pages)

sam-schu · 2026-02-25T18:22:44Z

apps/backend/src/pantries/types.ts

+  name: string;
+  email: string;
+  phone: string;
+  role: string;


I'm fine either way - this type seems to only be used as part of the return of the endpoint to get info about the approved pantries, where I agree it's not strictly necessary that we return the role of every assigned volunteer but it also doesn't hurt anything

swarkewalia added 2 commits December 3, 2025 17:47

get approved and update volunteer endpoints

62ca4fb

merge main

8907ee8

swarkewalia changed the title ~~get approved and update volunteer endpoints~~ SSF 97 pantry management backend Dec 4, 2025

bhuvanh66 mentioned this pull request Dec 5, 2025

[SSF-83] Fix security issues (Part 1) #74

Merged

sam-schu added the high priority label Dec 5, 2025

dburkhart07 self-requested a review December 6, 2025 18:27

swarkewalia added 3 commits December 12, 2025 22:37

merge

08d4047

merge fixes

d2aef46

fix typeorm

63fa43a

sam-schu added the blocked label Jan 1, 2026

swarkewalia force-pushed the sk/SSF-97-pantry-management-backend branch 2 times, most recently from 313c63d to 2577fbe Compare January 18, 2026 04:21

merge fix

265bad6

swarkewalia force-pushed the sk/SSF-97-pantry-management-backend branch from 2577fbe to 265bad6 Compare January 18, 2026 04:39

dburkhart07 requested changes Jan 18, 2026

View reviewed changes

sam-schu removed the blocked label Jan 18, 2026

swarkewalia added 9 commits January 20, 2026 16:58

Merge branch 'sk/SSF-97-pantry-management-backend' of https://github.…

1c948a7

…com/Code-4-Community/ssf into sk/SSF-97-pantry-management-backend

Merge branch 'main' of https://github.com/Code-4-Community/ssf into s…

ab18d04

…k/SSF-97-pantry-management-backend

Merge branch 'sk/SSF-97-pantry-management-backend' of https://github.…

4256a27

…com/Code-4-Community/ssf into sk/SSF-97-pantry-management-backend

merge fix

fb5ac86

gitignore fix

3489633

git ignore fix 2

72fc25d

auth service fix

ddda63f

extra files fixes

ba519d2

originally changed files

1681f42

dburkhart07 requested changes Jan 23, 2026

View reviewed changes

swarkewalia added 3 commits January 24, 2026 18:32

updated package.json

fe9f0fd

prettier

b1fffbb

fixed yarn.lock

0f9df9c

swarkewalia added 2 commits February 3, 2026 17:09

Merge branch 'main' of https://github.com/Code-4-Community/ssf into s…

a8a3289

…k/SSF-97-pantry-management-backend

Merge branch 'main' into sk/SSF-97-pantry-management-backend

dc53864

dburkhart07 requested changes Feb 4, 2026

View reviewed changes

apps/backend/src/pantries/pantries.controller.spec.ts Show resolved Hide resolved

apps/backend/src/pantries/pantries.controller.spec.ts Outdated Show resolved Hide resolved

swarkewalia added 5 commits February 4, 2026 18:36

add volunteers assigned to pantry

7fe16c0

Merge branch 'main' of https://github.com/Code-4-Community/ssf into s…

6aa3025

…k/SSF-97-pantry-management-backend

merge

18776f3

fixed more changes

b0591a0

dependency issues

f4e3893

swarkewalia added 2 commits February 15, 2026 11:22

final fixes

d29748f

merge

7a66455

swarkewalia requested a review from dburkhart07 February 15, 2026 17:12

nit

7f6edf9

dburkhart07 approved these changes Feb 16, 2026

View reviewed changes

swarkewalia added 2 commits February 16, 2026 23:48

Merge branch 'main' into sk/SSF-97-pantry-management-backend

cf9f2b6

Merge branch 'main' into sk/SSF-97-pantry-management-backend

82ea854

Yurika-Kan self-requested a review February 19, 2026 06:55

swarkewalia added 4 commits February 20, 2026 01:58

fix git tests

e88b4bd

conflicts

303c5c2

Merge branch 'main' into sk/SSF-97-pantry-management-backend

b9e4491

fix conflict

934e9db

Yurika-Kan requested changes Feb 22, 2026

View reviewed changes

swarkewalia added 4 commits February 21, 2026 23:22

merge

9f5e2e5

add shipmentstate

ff491af

prettier

97fbb5d

fix merge

994bf06

swarkewalia requested a review from Yurika-Kan February 22, 2026 04:50

Merge branch 'main' into sk/SSF-97-pantry-management-backend

0a78425

Yurika-Kan requested changes Feb 25, 2026

View reviewed changes

sam-schu reviewed Feb 25, 2026

View reviewed changes

		}


		async getApprovedPantriesWithVolunteers(): Promise<ApprovedPantryResponse[]> {

		@@ -16,6 +17,7 @@ import { Roles } from '../auth/roles.decorator';
		import { ValidationPipe } from '@nestjs/common';

		@@ -56,6 +58,11 @@ export class PantriesController {
		return this.pantriesService.getPendingPantries();
		}

Conversation

swarkewalia commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ℹ️ Issue 97

📝 Description

✔️ Verification

Uh oh!

dburkhart07 commented Dec 6, 2025

Uh oh!

dburkhart07 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dburkhart07 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dburkhart07 commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dburkhart07 left a comment

Choose a reason for hiding this comment

Uh oh!

Yurika-Kan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Yurika-Kan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sam-schu left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

swarkewalia commented Dec 3, 2025 •

edited

Loading

dburkhart07 commented Feb 13, 2026 •

edited

Loading

sam-schu left a comment •

edited

Loading

sam-schu Feb 25, 2026 •

edited

Loading