-
Notifications
You must be signed in to change notification settings - Fork 420
Equal constraints #1983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Equal constraints #1983
Conversation
This reverts commit f57f470.
|
nevermind, I definitely didn't understand how the angle constraint worked, the wrap around was a mistake. I'll fix it as soon as possible, hopefully tomorrow. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1983 +/- ##
==========================================
- Coverage 95.96% 95.95% -0.01%
==========================================
Files 29 29
Lines 7857 7896 +39
Branches 1174 1185 +11
==========================================
+ Hits 7540 7577 +37
- Misses 183 184 +1
- Partials 134 135 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Adds the
EqualandEqualRadiusconstraints metioned in #1979.While I was writing the tests and adding small perturbations to test the solver I noticed that the optimizer would not converge for some
Angleconstraints. With the wrap around inangle_cost, the delta is always minimal and the solver converges. No tests broke and I couldn't think of any case in which this modification would actually change the already established behavior but I would ask for a double, triple check.