Fix OIDC group-to-role sync for groups containing spaces#6022
Closed
SebastienMerv wants to merge 1 commit intoBookStackApp:developmentfrom
Closed
Fix OIDC group-to-role sync for groups containing spaces#6022SebastienMerv wants to merge 1 commit intoBookStackApp:developmentfrom
SebastienMerv wants to merge 1 commit intoBookStackApp:developmentfrom
Conversation
Normalize spaces to hyphens in parseRoleExternalAuthId() to match the same normalization applied to incoming group names in matchGroupsToSystemsRoles(), fixing group-to-role mapping for groups whose names contain spaces.
Member
|
Thanks for offering this @SebastienMerv but I'd be wary about changing the behaviour here, just in case of potential compatibility edge cases for existing values/environments, and to be safe in scenarios where users may assume the field is space separated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #6021
Normalize spaces to hyphens in parseRoleExternalAuthId() to match the same normalization applied to incoming group names in matchGroupsToSystemsRoles(), fixing group-to-role mapping for groups whose names contain spaces.