Conversation
…avaScriptProvider into zhiyuanliang/select-snapshot
Merge main to preview
…avaScriptProvider into zhiyuanliang/select-snapshot
…re/AppConfiguration-JavaScriptProvider into zhiyuanliang/select-snapshot
…re/AppConfiguration-JavaScriptProvider into zhiyuanliang/tag-filter
…ScriptProvider into zhiyuanliang/select-snapshot
…re/AppConfiguration-JavaScriptProvider into zhiyuanliang/tag-filter
…ScriptProvider into zhiyuanliang/select-snapshot
…re/AppConfiguration-JavaScriptProvider into zhiyuanliang/tag-filter
…ScriptProvider into zhiyuanliang/select-snapshot
…re/AppConfiguration-JavaScriptProvider into zhiyuanliang/tag-filter
…ScriptProvider into zhiyuanliang/tag-filter
avanigupta
reviewed
Jul 31, 2025
avanigupta
reviewed
Jul 31, 2025
avanigupta
reviewed
Jul 31, 2025
Member
|
Could you add more tests? You can refer to .net provider for different tag filter scenarios: https://github.com/Azure/AppConfiguration-DotnetProvider/blob/main/tests/Tests.AzureAppConfiguration/Unit/TagFiltersTests.cs Also, it would be good to include usage example for filtering tags with null value/empty value. This PR description can be modified to fit your PR too: Azure/AppConfiguration-DotnetProvider#637 (comment) |
…ScriptProvider into zhiyuanliang/tag-filter
Merged
…ScriptProvider into zhiyuanliang/tag-filter
RichardChen820
approved these changes
Aug 4, 2025
avanigupta
reviewed
Aug 4, 2025
Member
|
I dont see |
avanigupta
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this PR?
Extends the existing
SettingSelectortype forAzureAppConfigurationOptions.selectorsandFeatureFlagOptions.selectors.Now, you can pass tag filters that will be used to filter key-values and feature flags. Key-values and feature flags will only be returned if they contain all of the tags and corresponding values passed to the
tagFiltersparameter.Usage
Filtering for tags with empty/null value
You can construct a tag filter string like
"EmptyTag="and"NullTag=\0".