Silently fail when srv query fail#170
Merged
zhiyuanliang-ms merged 10 commits intomainfrom Feb 19, 2025
Merged
Conversation
zhiyuanliang-ms
requested review from
Eskibear,
Copilot,
linglingye001 and
rossgrambo
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/ConfigurationClientManager.ts:152
- Ensure that the new behavior of swallowing errors in #discoverFallbackClients is covered by tests.
console.warn(`Failed to build fallback clients, ${error.message}`);
zhiyuanliang-ms
force-pushed
the
zhiyuanliang/silent-srvquery-fail
branch
from
36cf602 to
2cd34f4
Compare
linglingye001
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this PR?
Fix the potential memory leak issue introduced by
Promise.race.If srv query failed or timed out, it should not fail the whole provider, instead, it should be a silent error.