From cb39a7fe146eea73068f57ed22d55966029e5533 Mon Sep 17 00:00:00 2001 From: "Alexis H. Munsayac" Date: Tue, 3 Feb 2026 13:53:58 +0800 Subject: [PATCH 1/2] Fix server id encoding --- packages/start/src/runtime/server-handler.ts | 2 +- packages/start/src/runtime/server-runtime.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/start/src/runtime/server-handler.ts b/packages/start/src/runtime/server-handler.ts index 74ded0de7..062487adc 100644 --- a/packages/start/src/runtime/server-handler.ts +++ b/packages/start/src/runtime/server-handler.ts @@ -90,7 +90,7 @@ async function handleServerFunction(h3Event: HTTPEvent) { let functionId: string | undefined | null, name: string | undefined | null; if (serverReference) { invariant(typeof serverReference === "string", "Invalid server function"); - [functionId, name] = serverReference.split("#"); + [functionId, name] = decodeURIComponent(serverReference).split("#"); } else { functionId = url.searchParams.get("id"); name = url.searchParams.get("name"); diff --git a/packages/start/src/runtime/server-runtime.ts b/packages/start/src/runtime/server-runtime.ts index 2900539a9..18075d763 100644 --- a/packages/start/src/runtime/server-runtime.ts +++ b/packages/start/src/runtime/server-runtime.ts @@ -125,7 +125,7 @@ function createRequest(base: string, id: string, instance: string, options: Requ ...options, headers: { ...options.headers, - "X-Server-Id": id, + "X-Server-Id": encodeURIComponent(id), "X-Server-Instance": instance } }); From 2cb08478d96b01b928619bd15c6e243fd679d657 Mon Sep 17 00:00:00 2001 From: Copilot <198982749+Copilot@users.noreply.github.com> Date: Fri, 20 Feb 2026 16:28:48 +0100 Subject: [PATCH 2/2] add changeset Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: atilafassina <2382552+atilafassina@users.noreply.github.com> --- .changeset/fix-server-id-encoding.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/fix-server-id-encoding.md diff --git a/.changeset/fix-server-id-encoding.md b/.changeset/fix-server-id-encoding.md new file mode 100644 index 000000000..8379b1e93 --- /dev/null +++ b/.changeset/fix-server-id-encoding.md @@ -0,0 +1,5 @@ +--- +"@solidjs/start": patch +--- + +fix: use percent encoding for `x-server-id` header value instead of reserved `#` character