diff --git a/src/main/java/org/prebid/server/bidder/oms/OmsBidder.java b/src/main/java/org/prebid/server/bidder/oms/OmsBidder.java index 81e1c8091f5..ad54caec341 100644 --- a/src/main/java/org/prebid/server/bidder/oms/OmsBidder.java +++ b/src/main/java/org/prebid/server/bidder/oms/OmsBidder.java @@ -32,8 +32,10 @@ public class OmsBidder implements Bidder { + private static final String PUBLISHER_ID_MACRO = "{{PublisherId}}"; private static final TypeReference> EXT_TYPE_REFERENCE = new TypeReference<>() { }; + private final String endpointUrl; private final JacksonMapper mapper; @@ -48,7 +50,7 @@ public Result>> makeHttpRequests(BidRequest request final ExtImpOms impExt = parseImpExt(request.getImp().getFirst()); final String publisherId = resolverPublisherId(impExt.getPid(), impExt.getPublisherId()); final String encodedPublisherId = HttpUtil.encodeUrl(publisherId); - final String url = "%s?publisherId=%s".formatted(endpointUrl, encodedPublisherId); + final String url = endpointUrl.replace(PUBLISHER_ID_MACRO, encodedPublisherId); return Result.withValue(BidderUtil.defaultRequest(request, url, mapper)); } catch (PreBidException e) { return Result.withError(BidderError.badInput(e.getMessage())); diff --git a/src/main/resources/bidder-config/oms.yaml b/src/main/resources/bidder-config/oms.yaml index 16c4a4cac08..be8e9354c6a 100644 --- a/src/main/resources/bidder-config/oms.yaml +++ b/src/main/resources/bidder-config/oms.yaml @@ -1,6 +1,6 @@ adapters: oms: - endpoint: http://rt.marphezis.com/pbs + endpoint: http://rt.marphezis.com/pbs?pid={{PublisherId}} meta-info: maintainer-email: prebid@onlinemediasolutions.com app-media-types: diff --git a/src/test/java/org/prebid/server/bidder/oms/OmsBidderTest.java b/src/test/java/org/prebid/server/bidder/oms/OmsBidderTest.java index 81b3186bc71..f912f04c8b5 100644 --- a/src/test/java/org/prebid/server/bidder/oms/OmsBidderTest.java +++ b/src/test/java/org/prebid/server/bidder/oms/OmsBidderTest.java @@ -35,7 +35,7 @@ public class OmsBidderTest extends VertxTest { - private static final String ENDPOINT_URL = "https://randomurl.com"; + private static final String ENDPOINT_URL = "https://randomurl.com?pid={{PublisherId}}"; private final OmsBidder target = new OmsBidder(ENDPOINT_URL, jacksonMapper); @@ -70,7 +70,7 @@ public void makeHttpRequestsShouldCreateExpectedUrl() { assertThat(result.getErrors()).isEmpty(); assertThat(result.getValue()).hasSize(1) .extracting(HttpRequest::getUri) - .containsExactly("https://randomurl.com?publisherId=otherTagId"); + .containsExactly("https://randomurl.com?pid=otherTagId"); } @Test @@ -86,7 +86,7 @@ public void makeHttpRequestsShouldCreateExpectedUrlWithPublisherId() { assertThat(result.getErrors()).isEmpty(); assertThat(result.getValue()).hasSize(1) .extracting(HttpRequest::getUri) - .containsExactly("https://randomurl.com?publisherId=12345"); + .containsExactly("https://randomurl.com?pid=12345"); } @Test