CAN Viewer - are major changes welcomed?

[pevsonic]

Hi all,

Firstly thanks for the work on python-can - it's a great module!

I was just wondering what the intended / ideal scope is for the viewer.py tool is? The motivation for me asking is that over the past few years I've developed a personal fork that was based on an earlier version of it where I've added quite a few features which make it a much more useful and powerful tool :

• Detailed breakdown of signal values within a message
  • Implemented in the main pane using a curses "tree view" style
  • Takes message / signal name, field and value definitions from a cantools database (supports dbc, sym etc)
• Optional (curses) sidebar to display detailed info :
  • Interface / bus details
  • CAN ID breakdown (protocol dependent)
  • CAN data breakdown (hex / bin decode inc highlighting decoded signals)
  • Frame statistics
  • Other internal application specific info

I'm sure these would be of use to others, but I'm not sure if the appropriate way to share is to integrate into python-can or if I should offer to the cantools project, or just make a separate standalone repo for it.

I feel like python-can is the first port of call given that I've forked from your existing code here, but I'd like to find out if it would be welcomed or not before I put the effort in!

~Pev